fix: make sure JAVA_HOME is used in bootstrapped file #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @ckipp01!
That looks great, except for the modules/test/metadata submodule change (that submodule shouldn't be touched by this PR, I think)
Ah weird, sorry I didn't even notice that! I'll get rid of it. |
I came across this for some Metals users that use coursier to bootstrap a metals executable. The executable just calls `java` and doesn't respect `JAVA_HOME`. This change makes sure that in the shell script if `JAVA_HOME` is set, it's used and if not we fall back to `java`. Closes #2048
alexarchambault
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this for some Metals users that use coursier to bootstrap
a metals executable. The executable just calls
javaand doesn'trespect
JAVA_HOME. This change makes sure that in the shell script ifJAVA_HOMEis set, it's used and if not we fall back tojava.Closes #2048