Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mill to 0.10.13, cleanup and fix deprecations #2874

Merged
merged 7 commits into from Nov 13, 2023
Merged

Update Mill to 0.10.13, cleanup and fix deprecations #2874

merged 7 commits into from Nov 13, 2023

Conversation

lefou
Copy link
Contributor

@lefou lefou commented Nov 10, 2023 •
edited

  • Update Mill to 0.10.13
  • Some obvious review fixes and updates
  • Enable some warnings and deprecations in build scripts
  • Fixed various compiler warnings
  • Replaced deprecated use of Tests traits

tgodzik
tgodzik reviewed Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question.

Do you want to add anything more here?

project/modules/cache0.sc Outdated Show resolved Hide resolved
@lefou
Copy link
Contributor Author

lefou commented Nov 10, 2023

Looks good! Just one question.

Do you want to add anything more here?

I want to migrate to Mill 0.11, but this is still a bit far, so a merge now makes sense. I'll remove the draft state once I think I'm done.

@lefou lefou marked this pull request as ready for review November 10, 2023 17:01
@lefou lefou requested a review from tgodzik November 10, 2023 21:57
@lefou lefou changed the title Build: cleanup and address deprecations Update Mill to 0.10.13, cleanup and address deprecations Nov 12, 2023
@lefou lefou changed the title Update Mill to 0.10.13, cleanup and address deprecations Update Mill to 0.10.13, cleanup and fix deprecations Nov 12, 2023
@lefou lefou mentioned this pull request Nov 13, 2023
Merged
tgodzik
tgodzik approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit ceb0459 into coursier:main Nov 13, 2023
22 checks passed
@lefou lefou deleted the mill011 branch November 13, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lefou @tgodzik