skip scorpio in usher mode #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the ubuntu actions, and the non-scorpio mode with usher no longer will give 'delta' constellations out
|
Are you happy with this @AngieHinrichs? Because scorpio is no longer run in usher mode, the pytests that check for "Delta.. etc" in the output file break, so for the meantime i've just removed that specific test from the actions. Running in fast mode for the pytests causes a memory error and I'm hestitant to put the specific AY assignment by usher into the tests because they may change in future. Other than the pytests, it was very straightforward to skip scorpio in usher mode and I think if this is the behaviour we want, this branch should be good to go! |
AngieHinrichs
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.