-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added skip-scorpio parameter fixes #234 #235
Conversation
what is the rationale behind it? |
This is a pangolin issue currently discussed in the community. The problem is that cov-lineages/scorpio#47 We performed some in-house tests annotation the full DESH collection w/ and w/o There is also a not yet merged PR (cov-lineages/pangolin#461) about that topic. So maybe the way |
@MarieLataretu but would it be not better to have a general EDIT: although checking the way you implemented it now is also nice. It's more explicit to have a parameter for deactivation directly in the help |
Yes, it's more explicit and if Of course |
but it sounds like it would be better to deactivate it by default or did i misunderstand this? |
I wasn't sure about changing the default behavior - I can change that to skip |
Yeah, that's the question. We could also deactivate it by default and write that in the release notes (citing also the discussions I mentioned here)? Could be just that when the Pango devs change also the default behavior in the tool itself we also might have to change that back. Assuming that many people just use the pipeline and report the results it might be even good we make this decision based on the current discussions and tests. So from my site also +1 to make this the current default |
i mean most users are probably not reading this so i would just set the defaults to the best practice. :) |
I changed the default to |
can we changed it to just |
@replikation yeah, I like that it's not so DoppeltGemoppelt btw the current release vs/ Maries master branch w/ scorpio deactivated: |
Done. |
Perfect. I'll run some tests and then merge. Thank you |
scorpio
is not skipped and can be skipped withpangolin_skip_scorpio