feat(icons): removed svg from tabs #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiheon
requested review from
a team,
toofff,
gdostie,
dmgauthier and
GermainBergeron
and removed request for
a team
gdostie
reviewed
May 10, 2022
![jenkins-dev-coveo[bot]](https://avatars.githubusercontent.com/in/73157?s=60&v=4){kind=small}
toofff
approved these changes
May 10, 2022
GermainBergeron
approved these changes
May 11, 2022
3 tasks
gdostie
approved these changes
May 11, 2022
gdostie
added a commit
that referenced
this pull request
Sep 21, 2022
* chore(release): publish version v38.11.4-next.0 [version bump] * feat(react-icons): implement Icon type Added a typescript type that represents an Icon from plasma-react-icon * feat(react-icons): add accessible role to all icons * feat(react): use plasma-react-icons in badge component Remove the usage of Svg in favour of plasma-react-icons BREAKING CHANGE: Badge icon prop now expects an icon from plasma-react-icons fix(react): fix badge tests * feat(react): use react-icons in CollapsibleToggle Switch out the Svg component for the icons from plasma-react-icons in the CollapsibleToggle component BREAKING CHANGE: CollapsibleToggleProps changed, svgClassName is no longer a prop * chore(release): publish version v38.11.4-next.1 [version bump] * chore(release): publish version v38.11.4-next.0 [version bump] * feat(react-icons): implement Icon type Added a typescript type that represents an Icon from plasma-react-icon * feat(react-icons): add accessible role to all icons * feat(react): use plasma-react-icons in badge component Remove the usage of Svg in favour of plasma-react-icons BREAKING CHANGE: Badge icon prop now expects an icon from plasma-react-icons fix(react): fix badge tests * feat(react): use react-icons in CollapsibleToggle Switch out the Svg component for the icons from plasma-react-icons in the CollapsibleToggle component BREAKING CHANGE: CollapsibleToggleProps changed, svgClassName is no longer a prop * chore(release): publish version v38.11.4-next.1 [version bump] * build(publish): add debugging information in publish script * chore(release): publish version v38.11.6 [version bump] * chore(release): publish version v38.11.4-next.2 [version bump] * feat(react): remove Svg from ActionableItem Switch out Svg for plasma-react-icons in ActionableItem component * chore(release): publish version v38.11.4-next.3 [version bump] * feat(tokens): extract design tokens from figma libraries * chore(release): publish version v38.11.4-next.1 [version bump] * chore(release): publish version v38.11.4-next.4 [version bump] * fix(website): remove workarounds Properly declaring plasma-react-icons as a module fixed the issue with nextjs 🎉 * chore(release): publish version v38.11.4-next.5 [version bump] * refactor(react): remove Svg from CollapsibleInfoBox Switch out the Svg component for the icon from plasma-react-icons in CollapsibleInfoBox * refactor(react): remove Svg from CollapsibleContainer Switch out the Svg component for icons from the plasma-react-icons packages * refactor(react): remove Svg from BrowserPreview Switch out the Svg for plasma-react-icons in BrowserPreview component where I could * chore(release): publish version v38.11.4-next.6 [version bump] * chore(release): publish version v38.11.4-next.7 [version bump] * chore(release): publish version v38.11.4-next.8 [version bump] * refactor(react): use plasma-react-icons in InfoToken Switch out the Svg component for plasma-react-icons in the InfoToken component * chore(release): publish version v38.11.4-next.9 [version bump] * refactor(icons, action bar): replace svg with icons * test: fix uts for lazy loading icons * refactor: applied review to pr * refactor: applied review again xD * chore(release): publish version v40.5.2-next.10 [version bump] * chore(release): publish version v41.2.10-next.11 [version bump] * fix(website): _react is not defined in sandbox * refactor(react): use new iconography for dropdown toggles * refactor(react): use new icons in date picker * refactor(react): use new icons in LinkSvg and Breadcrumbs * refactor(react): remove Svg from MultilineBox and MultiSelect * fix(react): fix failing test in MultiSelectConnected * fix(website): window is not defined on first load Using globalThis instead of window fixes everything * fix(website): use new icon in badge examples * feat(icons): removed svg from tabs (#2733) * feat(icons): removed svg from tabs * refactor: applied review to pr * fix(react): fix failing badge test * refactor(react): remove Svg from FilePicker * refactor(react): remove Svg from FilterBox * refactor(react): remove Svg from LabeledValue * refactor(react): remove Svg from Limit * refactor(react): remove Svg from modal close button * refactor(react): remove Svg from toast * refactor(react): remove Svg from TableCollapsibleRowToggle * fix(react): remove unused import in LabeledValue * feat(iconbadge): removed svg and using new icons (#2731) * feat(iconbadge): removed svg and using new icons * refactor: clean up * refactor: applied review to demo * chore(release): publish version v41.5.1-next.0 [version bump] * feat(react-icons): write Icon type manually Allow to manually write some code of the react-icons package instead of auto generating everything * fix(react): remove extra padding for icon only badge * refactor(react): remove Svg from BrowserPreviewError Use an img tag to load the previewError svg from plasma-style * refactor(react): remove Svg from BrowserPreviewEmpty * feat(react): delete Svg and SvgChild components Delete the Svg and SvgChild components BREAKING CHANGE: Svg and SvgChild no longer exist, either use icons from plasma-react-icons or img tag with an svg from plasma-style fix: linkSvg path changed * refactor(react): remove Svg from ActionsDropdown * refactor(react): remove Svg from ItemFilter * refactor(react): remove Svg from BlankSlate The blankslates will now accept Icons from the iconography instead of Svg BREAKING CHANGE: Blankslates no longer have svgName and svgClass props, use icon prop instead fix(website): use Icons in BlankSlate examples * refactor(react): remove Svg from Facet and FacetRow Svg component is getting replaced by icons from the Iconography * refactor(react): remove Svg from IconCard Replace usage of Svg by icons from the iconography BREAKING CHANGE: icon prop for choices now expects an icon from the iconography, .mod-fixed-size is getting removed, that doesn't belong in plasma * refactor(react,website): remove Svg from SideNavigation components replacing usage of Svg for icons from the iconography BREAKING CHANGE: svgName and svgClass props no longer exist, use icon prop instead * refactor(react): remove Svg from SearchBar * refactor: remove Svg from TableHeader * refactor(website,style): move the github icon in the website resources * refactor: remove Svg from NumericInput * refactor(dropdownsearch): replace usage of Svg by the Iconography * refactor(select): replace usages of Svg by the iconopgraphy * refactor: replace Svg with InfoToken in input labels * refactor(statuscard): replace usage of Svg by the iconography * refactor(menuconnected): replace usage of Svg by the iconography * refactor(pagination): replace usages of the Svg by the iconography * refactor(website): remove Svg usages in the website * refactor(jsoneditor): remove usages of the Svg component * refactor(syncfeedback): replace Svg by InfoToken * refactor(website): remove commented code * chore(release): publish version v41.5.1-next.1 [version bump] * chore(release): publish version v41.5.1-next.2 [version bump] * build(icons): fix version * chore(release): publish version v41.5.1-next.3 [version bump] * build(npm): fix version missmatch * chore(release): publish version v41.5.1-next.4 [version bump] * feat(tokens): extract design tokens from figma libraries * chore(release): publish version v41.5.1-next.5 [version bump] * fix(react): make ActionableItem display better (#2763) * fix(react): make ActionableItem display better The ActionableItem component looks a little weird, so I fixed that. Refactored its implementation and redid all its tests while at it. feat(actionable-item): open button background colour Let the hover background colour visible if the menu is opened * refactor: apply jsdocs fixes Co-authored-by: kdang-coveo <66333175+kdang-coveo@users.noreply.github.com> Co-authored-by: kdang-coveo <66333175+kdang-coveo@users.noreply.github.com> * fix(npm): make sure version number is valid * chore(release): publish version v42.1.5-next.0 [version bump] * chore(rebase): get latest changes from master(#2768) * feat(mvp, listbox): new style (#2761) * feat(mvp, listbox): new style for loading state * feat(mvp, listbox): styling scroll + card + text colors * feat(mvp, listbox): padding + adding flex and gap * feat(mvp, listbox): padding adjustment + new Empty state example * feat(mvp, listbox): styling the footer + final adjustment * refactor: removed unused variable * refactor: applied review to pr * test: fix broken uts * chore(release): publish version v42.2.0 [version bump] * feat(mvp, filter box): apply new style (#2751) * feat(mvp, filter box): apply new style * fix(mvp, filter box): adding bg color because input is white by default * feat(mvp, filter box): adding disabled state * test: redo uts in RTL expect some * docs(mvp, filterbox): adding example for disabled * refactor(mvp, filterbox): tweaked onChange to handle svg switch faster * test: remove tests * refactor: applied reviews to pr * refactor: applied review to pr * chore(release): publish version v42.3.0 [version bump] * fix(datepicker): fix button order + style (#2767) * fix(datepicker): fix button order + style * Update packages/react/src/components/datePicker/DatePickerDropdown.tsx Co-authored-by: Gaël Dostie <35579930+gdostie@users.noreply.github.com> Co-authored-by: Gaël Dostie <35579930+gdostie@users.noreply.github.com> * chore(release): publish version v42.3.1 [version bump] * feat(mvp, filter box): new style (#2766) * feat(mvp, filter box): apply new style * fix(mvp, filter box): adding bg color because input is white by default * feat(mvp, filter box): adding disabled state * test: redo uts in RTL expect some * docs(mvp, filterbox): adding example for disabled * feat(mvp, listbox): new style for loading state * feat(mvp, listbox): styling scroll + card + text colors * feat(mvp, listbox): padding + adding flex and gap * feat(mvp, listbox): padding adjustment + new Empty state example * feat(mvp, listbox): styling the footer + final adjustment * refactor: removed unused variable * refactor(mvp, filterbox): tweaked onChange to handle svg switch faster * test: remove tests * refactor: applied reviews to pr * refactor: applied review to pr * feat(mvp, single select): apply new style * feat(mvp, single-select): touch up on new style * refactor: applied review to pr * refactor: change active style with UX approval * refactor: oops * chore(release): publish version v42.4.0 [version bump] * Apply suggestions from code review Co-authored-by: Gaël Dostie <35579930+gdostie@users.noreply.github.com> Co-authored-by: Jenkins CI <jenkins@coveo.com> Co-authored-by: Gaël Dostie <35579930+gdostie@users.noreply.github.com> * fix(next): branch failing tests * chore(release): publish version v46.0.2-next.0 [version bump] * fix(style): fix some bad merge conflicts * chore(release): publish version v46.0.2-next.1 [version bump] * fix(iconcard): remove overflow hidden for custom logo img * chore(release): publish version v46.0.2-next.2 [version bump] * ci: fix husky commands not found * chore(release): publish version v46.0.2-next.3 [version bump] Co-authored-by: Jenkins CI <jenkins@coveo.com> Co-authored-by: Germain Bergeron <gbergeron@coveo.com> Co-authored-by: Ariane-Isabel <aiheon@coveo.com> Co-authored-by: Ariane-Isabel Héon <63734941+aiheon@users.noreply.github.com> Co-authored-by: kdang-coveo <66333175+kdang-coveo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
https://coveord.atlassian.net/browse/UITOOL-676
Before:
After:
Potential Breaking Changes
iconModStrokeis now deprecated and will have no effet on the icon.Acceptance Criteria