feat(source datasets): implementation #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgauthier
force-pushed
the
feat-TRI-145-web-dataset-implementation
branch
from
5904213
to
40a30fd
Compare
Comment on lines
+20
to
+24
| web = 'WEB', | ||
| /* | ||
| * Dataset for ecommerce search | ||
| */ | ||
| ecommerce = 'ecommerce', |
There was a problem hiding this comment.
Non-bidding comment, because I assume this is as such in the backend but, I think it'd be nice to have consistency on the format of the DatasetType. Here we have an all-cap and an all-lowercase, that's a bit odd.
There was a problem hiding this comment.
yes this is exactly like that in the backend. But I do agree with you and I dislike that 🙊 . But without those exact strings in the params we are going to hit 400s
louis-bompart
approved these changes
Oct 13, 2021
src/resources/Sources/index.ts
Outdated
| @@ -2,3 +2,4 @@ export * from './Sources'; | |||
| export * from './SourcesInterfaces'; | |||
| export * from './SourcesFields/'; | |||
There was a problem hiding this comment.
Non-bidding either, but it'd be nice to uniformize here and make it goes as such:
Suggested change
| export * from './SourcesFields/'; | |
| export * from './SourcesFields'; |
Just to be consistent.
louis-bompart
requested review from
a team,
toofff,
mikedidomizio and
sallainCoveo
and removed request for
olamothe and
a team
toofff
approved these changes
Oct 13, 2021
dmgauthier
force-pushed
the
feat-TRI-145-web-dataset-implementation
branch
2 times, most recently
from
5e36dcc
to
f1b92dc
Compare
dmgauthier
force-pushed
the
feat-TRI-145-web-dataset-implementation
branch
from
f1b92dc
to
ed19efc
Compare
|
🎉 This PR is included in version 25.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria