refactor(paginated): add common interface for paginated calls #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
a team,
GermainBergeron,
FelixBlaisThon and
sallainCoveo
and removed request for
a team
louis-bompart
commented
May 12, 2022
| @@ -1,5 +1,4 @@ | |||
| # Logs | |||
| logs | |||
There was a problem hiding this comment.
Otherwise, src/resources/Logs get ignored. 🤣
sallainCoveo
approved these changes
May 12, 2022
toofff
approved these changes
May 12, 2022
GermainBergeron
approved these changes
May 13, 2022
y-lakhdar
approved these changes
May 16, 2022
|
🎉 This PR is included in version 30.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a 'base' interface for the
listcalls.This interface for now excludes some outliers, Snapshot & Catalog, because the REST APIs are not following the historic standard of
perPagefor the number of items per page.We could (in another PR to keep the scope accurate) expose a
perPageargument that would be used as an alias for their equivalent.Tips for review, ignore whitespace... We had a discussion on Slack about that, will be normalized 🔜 ™️
Acceptance Criteria