-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(SFINT-2577): Ensure Prettier run properly on UNIX. #43
ci(SFINT-2577): Ensure Prettier run properly on UNIX. #43
Conversation
19acba5 failed as expected. |
@@ -1,10 +1,10 @@ | |||
*.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably a silly question but what is different here? The changes look the same to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such thing has a silly question ;P
It's the end of line terminator that have changed: it was a CRLF, it's now a LF, as specified by the .prettierrc.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Thanks Louis!
@@ -23,8 +23,8 @@ | |||
"css": "node ./scripts/css.js", | |||
"dev": "node ./scripts/dev.server.js", | |||
"watchTest": "karma start ./config/karma.config.js", | |||
"lint": "prettier --check **/*", | |||
"lint-fix": "prettier --write **/* ", | |||
"lint": "prettier --check \"./**/*\" --config \".prettierrc.js\" --ignore-path \".prettierignore\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not targetting the json instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I changed it to a .js to be consistent with the other config files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So where is you change to enable linux ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the wrapping of the glob (so **/*
to \"./**/*\"
)
The glob was not resolved the same way due to escaping on bash vs Powershell, this is now fixed.
Also now using the standard .prettierrc.js, because .json is not standard.
Bash were the ones with degradation, and thus the CI did not trip on linting ('cause he's on Ubuntu)