fixeat(SFINT-3295): Improve UserActions interactivity #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to use the UserAction without him being tied to the ResponsiveComponentManager and without creating a ResponsiveHeaderButton.
louis-bompart
requested review from
jeremierobert-coveo,
lbergeron,
enadeauCoveo,
mikegron,
nathanlb and
tedre191
louis-bompart
commented
Jul 8, 2020
| this.renderNoActions(); | ||
| } | ||
| } catch (e) { | ||
| if (e && e.statusCode === 404) { |
There was a problem hiding this comment.
Wanted to use optional chaining, was not able because of prettier, so #80 should fix it and allow latest TypeScript features to be used.
enadeauCoveo
reviewed
Jul 8, 2020
| this.renderNoActions(); | ||
| } | ||
| } catch (e) { | ||
| if (e && e.statusCode === 404) { |
There was a problem hiding this comment.
Why are we only checking for status code 404?
There was a problem hiding this comment.
I think we're still considering the others status code, but do not wish to take special action for them other than render no actions.
I'm guessing that if https://platformqa.cloud.coveo.com/docs/?api=Reveal#!/User32Profiles/rest_organizations_paramId_machinelearning_user_actions_post answer 404, it means the feature is not enabled on the client organization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add useResponsiveManager option
Add a useResponsiveManager option, default to true. Previous behaviour is kept, meaning that if you have hidden, the useResponsiveManager will be inoperant because hidden does super-seed it.
It allows SFINT to use the UserActions without hooking it to the ResponsiveComponentManager, will preserving its other functionality.
Add events for show and hide of the UserActions panel
Allow other components to be notified of when the UserActions panel is shown or hidden.
It allows SFINT to sync up the state of the ToggleActionButton with the panel when the latter get closed by something else than the button (e.g. query)
Tests