chore(SFINT-3308): Update prettier and ran it #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergeron
requested changes
Jul 8, 2020
There was a problem hiding this comment.
It looks good to me. You should update the readme as Prettier dropped the support of NodeJS < 10.
https://github.com/coveo/search-ui-extensions/blob/master/README.md#setup
Agreed, but to keep the 'linting' in its own PR, I will modify it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
npm i prettier@latest -E -Dinstalled latest prettier versionnpm run lint-fixformat all the projectgit add . ; git commitadd every change and commit.I choose deliberately to not do any changes to the prettier config and just follow what's recommended by prettier for the new stuff - so don't add anything in prettierrc, in a perfect world, you should not even have one-.
You can find information about the changes here:
https://prettier.io/blog/2020/03/21/2.0.0.html