Update node requirement to node 10 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegron
approved these changes
Jul 8, 2020
|
Lodash do an update, |
lbergeron
approved these changes
Jul 8, 2020
README.md
Outdated
| @@ -9,7 +9,7 @@ This repository contains new components meant to be used in conjunction with the | |||
|
|
|||
| ## Setup | |||
|
|
|||
| Requires Node JS >= 8.0. | |||
| Requires Node JS >= 10.13.0. | |||
There was a problem hiding this comment.
Out of curiosity, why 10.13.0 specifically? The latest 10.x version is 10.21.0.
There was a problem hiding this comment.
Bad google cache, I was checking the snippet from Node JS. Will update. Imposing Node 12.18.2, because it's the current LTS.
I'm a fervent partisan to try to always be on the current LTS, and not the maintenance LTS, just because its a good way to prevent late update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory.
Come from #80