Defensive code against undefined values (#315)

UT https://coveord.atlassian.net/browse/JSUI-1419
coveo · Feb 7, 2017 · 4b3055d · 4b3055d
1 parent 6ce4462
commit 4b3055d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/utils/HashUtils.ts b/src/utils/HashUtils.ts
@@ -48,7 +48,7 @@ export class HashUtils {
         encodedValue = HashUtils.encodeArray(valueToEncode);
       } else if (_.isObject(valueToEncode) && Utils.isNonEmptyArray(_.keys(valueToEncode))) {
         encodedValue = HashUtils.encodeObject(valueToEncode);
-      } else {
+      } else if (!Utils.isNullOrUndefined(valueToEncode)) {
         encodedValue = encodeURIComponent(valueToEncode.toString());
       }
       if (encodedValue != '') {

diff --git a/test/utils/HashUtilsTest.ts b/test/utils/HashUtilsTest.ts
@@ -68,6 +68,14 @@ export function HashUtilsTest() {
       expect(encodedValue).toEqual(expectedEncodedValue);
     });
 
+    it('should not throw when encoding null or undefined values', () => {
+      let toEncode = null;
+      let expectedEncodedValue = '';
+      let encodedValue = HashUtils.encodeValues({ a: toEncode });
+      expect(() => HashUtils.encodeValues({ a: toEncode })).not.toThrowError();
+      expect(encodedValue).toEqual(expectedEncodedValue);
+    });
+
     it('joins values correctly', () => {
       let firstValue = 'test';
       let secondValue = [1];