Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate atomic-did-you-mean #3999

Merged
merged 2 commits into from
May 27, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented May 24, 2024

This pull request migrates the Storybook stories for the atomic-did-you-mean component, aligning with the recent changes made to the atomic-no-results component stories.

  • Migrates Storybook stories: Adds a new story file atomic-did-you-mean.new.stories.tsx with a configuration that ensures no results are returned and a query correction is provided, to demonstrate the atomic-did-you-mean component in action. This replaces the old atomic-did-you-mean.stories.tsx file, which has been removed.
  • Enhances wrapInSearchInterface utility: Updates the wrapInSearchInterface function in storybookUtils/search-interface-wrapper.tsx to accept a configuration object. This allows for more flexible story configurations, as utilized in the new atomic-did-you-mean story.

For more details, open the Copilot Workspace session.

@louis-bompart louis-bompart requested a review from a team as a code owner May 24, 2024 05:05
@louis-bompart louis-bompart requested review from olamothe, fpbrault and y-lakhdar and removed request for a team May 24, 2024 05:05
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 274.9 274.9 0
search 367.3 367.3 0
insight 347.8 347.8 0
product-listing 261.9 261.9 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.1 360.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Base automatically changed from stories/no-results to nx-storybook May 27, 2024 14:25
@louis-bompart louis-bompart force-pushed the louis-bompart/stories/atomic-did-you-mean branch from d2247d6 to 45a23e7 Compare May 27, 2024 14:37
@louis-bompart louis-bompart merged commit 76038a7 into nx-storybook May 27, 2024
1 of 2 checks passed
@louis-bompart louis-bompart deleted the louis-bompart/stories/atomic-did-you-mean branch May 27, 2024 14:37
louis-bompart added a commit that referenced this pull request May 30, 2024
This pull request migrates the Storybook stories for the
`atomic-did-you-mean` component, aligning with the recent changes made
to the `atomic-no-results` component stories.

- **Migrates Storybook stories**: Adds a new story file
`atomic-did-you-mean.new.stories.tsx` with a configuration that ensures
no results are returned and a query correction is provided, to
demonstrate the `atomic-did-you-mean` component in action. This replaces
the old `atomic-did-you-mean.stories.tsx` file, which has been removed.
- **Enhances `wrapInSearchInterface` utility**: Updates the
`wrapInSearchInterface` function in
`storybookUtils/search-interface-wrapper.tsx` to accept a configuration
object. This allows for more flexible story configurations, as utilized
in the new `atomic-did-you-mean` story.


---

For more details, open the [Copilot Workspace
session](https://copilot-workspace.githubnext.com/coveo/ui-kit/pull/3991?shareId=bd6c696b-c4a6-4bdb-a99e-6a5cd4348f3e).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages/atomic/src/components/search/atomic-did-you-mean/atomic-did-you-mean.stories.tsx
1 participant