fix(Commerce Atomic): add commerce category facet #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Lamothe <olamothe@coveo.com>
…-facets/atomic-commerce-facets.tsx Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
…-facets/atomic-commerce-facets.tsx Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
y-lakhdar
requested review from
olamothe,
fpbrault and
louis-bompart
and removed request for
a team
y-lakhdar
commented
May 27, 2024
...atomic/src/components/commerce/atomic-commerce-product-list/atomic-commerce-product-list.tsx
Outdated
Show resolved
Hide resolved
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
olamothe
approved these changes
May 27, 2024
Spuffynism
approved these changes
May 28, 2024
...ages/atomic/src/components/commerce/facets/atomic-commerce-facets/atomic-commerce-facets.tsx
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fpbrault
added a commit
that referenced
this pull request
May 31, 2024
### Add Commerce Category Facet now rendering `atomic-commerce-category-facet` component ### Refactor Listing/Summary builder Build Listing/Search Summary controller in facet generator, and then pass it to the facets. Otherwise, each facet has to builds its own which cause code duplication. ## Fixes ### response id getter Fetch responseId from the appropriate variable in [atomic-commerce-product-list.tsx](KIT-3197...KIT-3200#diff-755504d8edb4af1c62f81e58f159ff3861c8ebe161f133941bbfd4e0ffebbb70) https://coveord.atlassian.net/browse/KIT-3200 --------- Co-authored-by: Olivier Lamothe <olamothe@coveo.com> Co-authored-by: GitHub Actions Bot <> Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com> Co-authored-by: Louis Bompart <lbompart@coveo.com> Co-authored-by: Felix Perron-Brault <fpbrault@coveo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Commerce Category Facet
now rendering
atomic-commerce-category-facetcomponentRefactor Listing/Summary builder
Build Listing/Search Summary controller in facet generator, and then pass it to the facets. Otherwise, each facet has to builds its own which cause code duplication.
Fixes
response id getter
Fetch responseId from the appropriate variable in atomic-commerce-product-list.tsx
https://coveord.atlassian.net/browse/KIT-3200