Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-3190 [GitHub] Add support for "GitHub" credentials type in credentials-sync #87

Merged
merged 3 commits into from
Jul 21, 2020
Merged

DT-3190 [GitHub] Add support for "GitHub" credentials type in credentials-sync #87

merged 3 commits into from
Jul 21, 2020

Conversation

ycanty
Copy link
Contributor

@ycanty ycanty commented Jul 21, 2020 •
edited by dblanchette

Main changes:

  • Added new source type "github_app"
  • Updated the documentation in the README
  • Tested successfully on one of our Jenkins instance: Succesful sync of a github_app credential that appeared correctly in the Jenkins UI.

Other changes:

  • Ran go fmt and golint on the codebase
  • Fixed warnings reported by the IDE
  • (go.mod) Updated gojenkins library to latest released version
  • (credentials.go) Better error messages when parsing of config fails
  • (credentials_test.go) Added more tests to cover all valid source types

@ycanty
DT-3190 [GitHub] Add support for "GitHub" credentials type in credent…
5531f64 
…ials-sync

Main changes:
* Added new source type "github_app"
* Updated the documentation in the README

Other changes:
* Ran go fmt and golint on the codebase
* Fixed warnings reported by the IDE
* (go.mod) Updated gojenkins library to latest released version
* (credentials.go) Better error messages when parsing of config fails
* (credentials_test.go) Added more tests to cover all valid source types
dblanchette
dblanchette approved these changes Jul 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
credentials/credentials.go Show resolved Hide resolved
credentials/credentials.go Show resolved Hide resolved
credentials/credentials_github_app.go Outdated Show resolved Hide resolved
credentials/credentials_github_app.go Outdated Show resolved Hide resolved
ycanty and others added 2 commits July 21, 2020 15:49
@ycanty ycanty merged commit 4ef0e65 into master Jul 21, 2020
@ycanty ycanty deleted the feature/dt-3190-github-creds branch July 21, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblanchette dblanchette dblanchette approved these changes

@julienduchesne julienduchesne Awaiting requested review from julienduchesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ycanty @dblanchette