Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-3190 [GitHub] Add support for "GitHub" credentials type in credentials-sync #87

Merged
merged 3 commits into from
Jul 21, 2020
Merged

DT-3190 [GitHub] Add support for "GitHub" credentials type in credentials-sync #87

merged 3 commits into from
Jul 21, 2020

Commits on Jul 21, 2020

  1. DT-3190 [GitHub] Add support for "GitHub" credentials type in credent… 

    …ials-sync

Main changes:
* Added new source type "github_app"
* Updated the documentation in the README

Other changes:
* Ran go fmt and golint on the codebase
* Fixed warnings reported by the IDE
* (go.mod) Updated gojenkins library to latest released version
* (credentials.go) Better error messages when parsing of config fails
* (credentials_test.go) Added more tests to cover all valid source types
    @ycanty
    ycanty committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    5531f64 View commit details
    Browse the repository at this point in the history

  2. Update credentials/credentials_github_app.go 

    Co-authored-by: Denis Blanchette <dblanchette@coveo.com>
    @ycanty @dblanchette
    ycanty and dblanchette committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    5a9433a View commit details
    Browse the repository at this point in the history

  3. Update README + make sure of showSensitive

    @ycanty
    ycanty committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    7ae992f View commit details
    Browse the repository at this point in the history