Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Android version #116

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timwright35
Copy link

I have been working on adding and refining features in the android version of the plugin.

Changes so far:
-A end datetime that uses the expire function of the google api
-Added frequency and last shown time that will allow you to control when a notification will show, ie every hour you are in the fence etc.
-Added Dwell and usable functions from the google api for dwell
-Change the intent flags for the notification so the app will be pulled to the front if it is not unloaded instead of reloading etc time
-Due to above change, added code to detect new intent and run notification clicked (Might need work)
-Added in option for notification responsiveness via google api
-Variety of other changes

All changes are to Android only side at the moment and have not been full tested, working on that. I also will look into making similar changes, if needed to iOS etc.

Adding pull request now so a discussion of changes etc can be had.

… responsiveness, loitering delay, lastShown, frequency, etc. Also changed how the intent for a notification is set so that the app is not reloaded if in background or foreground, only when unloaded.
@tsubik
Copy link
Member

tsubik commented Jan 24, 2016

Hey, thanks for PR. I'm in the middle of rewriting android part a little bit to get rid of deprecations, but with some changes, I could merge this pull request.

@timwright35
Copy link
Author

I changed the files based on your input, the getExpireTime might need work. I also moved the store for last shown up, is that where you meant when you commented on it?

@timwright35
Copy link
Author

Had a quick question about iOS version, no clue where to put it and could not find online. Is there a similar function to the autoCancel function on the iOS version? IE Can I stop the notification from disappearing when clicked on in the iOS version.

@timwright35
Copy link
Author

Also realized for accuracy it might be better to send in a timestamp on endDate not a formatted string. Think I might change that

@tsubik
Copy link
Member

tsubik commented Jan 26, 2016

I have no idea of iOS has something like autocancel. If timestamp you should change name to endAt or maybe expireAt.

@timwright35
Copy link
Author

So something I changed or something from before is causing the receiveTransition service to crash after a while. I will be looking into this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants