Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mongo-express service.nodePort configurable #37

Closed
DanielBican opened this issue Sep 3, 2020 · 4 comments
Closed

Make mongo-express service.nodePort configurable #37

DanielBican opened this issue Sep 3, 2020 · 4 comments

Comments

@DanielBican
Copy link

I am using mongo-express for a personal project and I am really happy with it. Great work:)
There is a small enhancement that I would benefit from, namely to make the service.targetPort configurable. I am using service.type=NodePort.

@sebastien-prudhomme
Copy link
Contributor

This is a change i know i need to do, thanks to recall me :-)

@sebastien-prudhomme
Copy link
Contributor

@DanielBican I've misread your need. I thought you want to customize service nodePort. What is your use case of having a custom targetPort?

@DanielBican
Copy link
Author

DanielBican commented Sep 3, 2020 via email

@sebastien-prudhomme sebastien-prudhomme changed the title Make mongo-express service.targetPort configurable Make mongo-express service.nodePort configurable Sep 4, 2020
@sebastien-prudhomme
Copy link
Contributor

This is fixed in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants