Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Goerli to the networks.json file #11

Closed
nenadV91 opened this issue May 26, 2022 · 4 comments
Closed

Add Goerli to the networks.json file #11

nenadV91 opened this issue May 26, 2022 · 4 comments

Comments

@nenadV91
Copy link

nenadV91 commented May 26, 2022 •
edited

We created a PR on the FE for the Goerli network implementation but seems like we need to do some stuff on the BE side and then to add the Goerli addresses to this file https://github.com/cowprotocol/contracts/blob/main/networks.json such as GPv2Settlement and GPv2VaultRelayer etc...

So in total we would need the following things

https://barn.api.cow.fi/goerli/api
https://api.cow.fi/goerli/api
https://safe-transaction.goerli.gnosis.io (is this already working?)
https://safe-relay.goerli.gnosis.io/api/v1/gas-station/ (is this already working?)

GP_SETTLEMENT_CONTRACT_ADDRESS
GP_VAULT_RELAYER
V_COW_CONTRACT_ADDRESS
COW_CONTRACT_ADDRESS
GNO address

For locked GNO
MERKLE_DROP_CONTRACT_ADDRESSES
TOKEN_DISTRO_CONTRACT_ADDRESSES
@nenadV91 nenadV91 mentioned this issue May 26, 2022
Merged
@fedgiac
Copy link
Contributor

fedgiac commented Jun 7, 2022 •
edited

All contracts in this repo have been deployed to Görli, the addresses are the same as on mainnet (see #13). This should be all the code changes required from this repository.

This means:

GP_SETTLEMENT_CONTRACT_ADDRESS="0x9008d19f58aabd9ed0d60971565aa8510560ab41"
GP_VAULT_RELAYER="0xC92E8bdf79f0507f65a392b0ab4667716BFE0110"

I opened an issue on the token repo to track the progress on deploying COW and vCOW tokens here: cowprotocol/token#2. Comments on how this should be handled (e.g., how/to whom the token is distributed) are welcome.

For our APIs, progress is tracked here: cowprotocol/services#155.

There is some code that isn't tracked by a repo controlled by us, namely:

  • GNO address
    I believe there is no Gnosis-sanctioned GNO address on Görli. Note that this address must be consistent with the infrastructure for locked GNO discussed next.
  • MERKLE_DROP_CONTRACT_ADDRESSES, TOKEN_DISTRO_CONTRACT_ADDRESSES
    This would probably be handled by the team who handled the testing for locked GNO. How does it work currently on Rinkeby @nenadV91? It would probably be complex to set up the whole infrastructure of their contracts by ourselves, and they might be already have a test version of the contract.
  • https://safe-transaction.goerli.gnosis.io/ https://safe-relay.goerli.gnosis.io/api/v1/gas-station/
    I believe this is already working as the Safe already supports Görli on the web interface.

@anxolin
Copy link
Contributor

anxolin commented Jun 9, 2022

I believe there is no Gnosis-sanctioned GNO address on Görli. Note that this address must be consistent with the infrastructure for locked GNO discussed next.

I think we can do a new deployment with this https://github.com/gnosis/gno-token, mint a lot of GNO and send us some.
At least this is what we've done in the past for Kovan and Rinkeby

@anxolin
Copy link
Contributor

anxolin commented Jun 9, 2022

MERKLE_DROP_CONTRACT_ADDRESSES, TOKEN_DISTRO_CONTRACT_ADDRESSES
This would probably be handled by the team who handled the testing for locked GNO. How does it work currently on Rinkeby @nenadV91? It would probably be complex to set up the whole infrastructure of their contracts by ourselves, and they might be already have a test version of the contract.

@nenadV91 can we just not have this feature in this network? Only if we deprecate Rinkeby we should put some effort to it

@fedgiac
Copy link
Contributor

fedgiac commented Aug 19, 2022

Closing as CoW Swap is now available on Görli.

@fedgiac fedgiac closed this as completed Aug 19, 2022
fleupold added a commit that referenced this issue Aug 25, 2023
@fleupold
Fix CD by pinning older docker image (#60)
9a672fb 
When currently building the docker image of the contract, we are not
including any artefacts, which - when running any hardhat script -
yields the following error:

```
HardhatError: HH700: Artifact for contract "src/contracts/interfaces/IERC20.sol:IERC20" not found. 
```

When looking at the build history we can see a subtle difference between
a build [that is
working](https://github.com/cowprotocol/contracts/actions/runs/5974729999/job/16209505930#step:5:253)
and [one that
isn't](https://github.com/cowprotocol/contracts/actions/runs/5975825913/job/16212645253#step:5:248):

```
#11 0.750 $ hardhat compile --force
#11 4.073 Warning: unable to recover token list from 1inch
#11 4.364 Downloading compiler 0.7.6
#11 4.826 Downloading compiler 0.7.6
**#11 17.88 Compiled 58 Solidity files successfully**
#11 18.27 $ tsc && tsc -p tsconfig.lib.esm.json && tsc -p tsconfig.lib.commonjs.json
```

vs

```
#11 0.860 $ hardhat compile --force
#11 4.335 Warning: unable to recover token list from 1inch
#11 4.646 Downloading compiler 0.7.6
#11 5.211 $ tsc && tsc -p tsconfig.lib.esm.json && tsc -p tsconfig.lib.commonjs.json
```

The latter doesn't seem to compile any artefacts. According to
NomicFoundation/hardhat#3877 this is due to a
URL parser behavior change in Node 18.16 that can lead to silent
Download failures. It's still no entirely clear to me why it sometimes
works (maybe because of some intermittent error)

### Test Plan

I hope this works, or at least tells us why the files are not being
compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anxolin @nenadV91 @fedgiac