Rewrite AppData sync using csv upload feat #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
So glad you are finally using the upload CSV endpoint! I mentioned this to @fhenneke several months ago. Be aware that this endpoint consumes API credits, so performing this regularly might use a lot (while the old solution would have remained free indefinitely).
Note that you can now also remove all the AWS dependencies and utilities from this code base (to make sure you caught everything).
harisang
reviewed
Jul 11, 2024
fhenneke
reviewed
Jul 11, 2024
tests/e2e/test_sync_app_data.py
Outdated
| max_retries=2, | ||
| give_up_threshold=3, | ||
| self.dune = DuneClient(os.environ["DUNE_API_KEY"]) | ||
| self.fetcher = DuneFetcher(self.dune) |
There was a problem hiding this comment.
DuneFetcher does not seem to be used anywhere. Would it be safe to remove that class?
|
Ahh it's just part of the storage plan on the data set. But looks like you've got 15Gb on the plus plan so nothing to worry about. |
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dramatically simplifies the way we sync app_data into Dune. Instead of looking for hashes we see on Dune for which we don't have the app_data pre-image and then trying to fetch this data from IPFS, we simply mirror the entire app_data pre-image table we have locally to Dune using their csv upload feature.
We ensured that we are no longer seeing orders for which app_data can only be retrieved from IPFS (to the contrary, we see more and more orders for which the pre image has only been written into the DB).
In order to achieve this, we
sync/app_data.pyand its configuration to basically be a full tablescan from the backend which gets written using the CSV upload feature of the dune python clientApp data for each network (mainnet, gnosis, arbitrum) will be written in its own table (since each network requires a separate db connection to the designated target db).
The table name can be specified as an additional parameter (which feels a bit 🤡, I'm not sure how sync job specific arguments were envisioned in the current architecture)
Test Plan
Both
python3 -m src.main --sync-table app_dataas well aspython -m pytest tests/e2e/test_sync_app_data.pypass