-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
Thank you for this new konnector! Before merging it, it would be better if the code follows the Cozy guidelines: What is missing:
Can you handle it? |
Yes I will.
I had to replace it with:
I followed https://github.com/cozy-labs/konnectors/wiki#data-description-models |
I don't know what's wrong except the fact you declared the vendor field twice. Indentation doesn't look proper too. |
The indentation is only wrong because I copy/pasted this block wrong. That was probably that the Bill model was already declared. Thanks, I can see the wiki has then been updated :). Why does the Bill model uses "Digital Ocean" as the default vendor ? |
Great! Thank you @nicofrand for this konnector. About the Digital Ocean as a vendor it's a mistake that will be fixed soon. Thank you again for the bug reports. |
Where do you see that save_data_and_file already sets the vendor automatically ? When it does, does it use the third parameter: I suggest to complete the wiki with those information. |
@nicofrand , the third parameter will set the vendor automatically, if it is not already set in the bill object you created when you parsed them form the website. |
Thanks @ZeHiro , I updated the wiki so that is it clear now. |
That should fix #56.