Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish #1568

Merged
merged 2 commits into from Sep 12, 2019
Merged

Polish #1568

merged 2 commits into from Sep 12, 2019

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented Sep 12, 2019 •
edited

  • The header had no base height since Content was not in display flex

Otherwise on mobile, when the History chart is not displayed because of
Delayed, the Header had not height. It made the content below jump when
the History got displayed.

I put important! since it should be cozy-ui doing this.

  • Diminish the number of spinner by using fetch policies and hasBeenLoaded

@ptbrowne
fix: Display flex on Content so that the header has a base height
bf9c215 
Otherwise on mobile, when the History chart is not displayed because of
Delayed, the Header had not height. It made the content below jump when
the History got displayed.
@todo
Copy link

todo bot commented Sep 12, 2019

should not be necessary, the Main component in cozy-ui should

cozy-banks/src/components/App.styl

Lines 2 to 5 in bf9c215

// TODO should not be necessary, the Main component in cozy-ui should
// already have that
// See https://github.com/cozy/cozy-ui/issues/1156
display flex !important

This comment was generated by todo based on a TODO comment in bf9c215 in #1568. cc @cozy.

@ptbrowne ptbrowne changed the title fix: Display flex on Content so that the header has a base height Polish Sep 12, 2019
@ptbrowne
feat: Use global query specs and hasBeenLoaded
e6bcb05 
Not to show many spinners all the time
drazik
drazik approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@drazik drazik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@ptbrowne ptbrowne merged commit 1e51036 into master Sep 12, 2019
@todo todo bot mentioned this pull request Sep 12, 2019
Open
@delete-merged-branch delete-merged-branch bot deleted the fix-jumping-content branch September 12, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drazik drazik drazik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptbrowne @drazik