Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to cookie-base authentication if no oauth parameters are given #30

Merged
merged 4 commits into from
Jan 5, 2017

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Jan 5, 2017

By implementing OAuth, I removed the possibility to use cookie-based authentification.

This PR makes it the default (ie. not using Authorization header) if no oauth parameters are given to the init method.

@aenario
Copy link
Contributor

aenario commented Jan 5, 2017

@jinroh To send cookies in modern browser (which have a native fetch function), you need to explicitly enable it by adding a credentials option to fetch (ref https://github.com/github/fetch#sending-cookies)

@aenario aenario merged commit 4b8ee07 into master Jan 5, 2017
@aenario aenario deleted the default-to-cookie-auth branch January 5, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants