New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CozyClient can be used in a node env #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
requested review from
Crash--,
trollepierre,
Merkur39 and
paultranvan
as code owners
May 25, 2022 16:40
Ldoppea
force-pushed
the
fix/handle_window_not_defined
branch
from
May 25, 2022 16:43
001c20f
to
eb0460f
Compare
Previous fix tried to handle undefined `window` in node env But in a node env window is not `undefined` as it is not even an existing variable So instead of checking its value, a better way is to check its type as `typeof` will return `'undefined'` when called with a variable that does not exist Related commit: 509a0ca
Ldoppea
force-pushed
the
fix/handle_window_not_defined
branch
from
May 25, 2022 16:44
eb0460f
to
2b963c6
Compare
paultranvan
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-banks
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
This was referenced May 27, 2022
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-banks
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-banks
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-banks
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-banks
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
May 27, 2022
`cozy-client` as been upgraded to to `29.1.1` to retrieve fix about broken services from cozy/cozy-client#1180
paultranvan
added a commit
to cozy/coachCO2
that referenced
this pull request
May 30, 2022
paultranvan
added a commit
to cozy/coachCO2
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix tried to handle undefined
window
in node envBut in a node env window is not
undefined
as it is not even anexisting variable
So instead of checking its value, a better way is to check its type as
typeof
will return'undefined'
when called with a variable thatdoes not exist
Related commit: 509a0ca
Following test is success with the new fix if run from a
node
envFollowing test is success with the new fix if run from a
jsdom
env