Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): prevent duplicate API called when suggestions are fetched #2685

Merged
merged 1 commit into from Sep 2, 2022

Conversation

trollepierre
Copy link
Contributor

@trollepierre trollepierre commented Sep 2, 2022

In production build, the number of Suggestions looks duplicated (or worst)
In order to prevent the duplicate called, we should set the fetching
indicator directly when we call indexFiles method

Before:
Capture d’écran 2022-09-02 à 16 38 51

  • Changelog updated if needed

In production build, the number of Suggestions looks duplicated (or worst)
In order to prevent the duplicate called, we should set the fetching
indicator directly when we call indexFiles method
@bundlemon
Copy link

bundlemon bot commented Sep 2, 2022

BundleMon

Unchanged files (10)
Status Path Size Limits
public/drive.(hash).js
1.46MB 1.6MB
vendors/drive.(hash).js
1.4MB 1.54MB
services/dacc/drive.js
248.5KB 249KB
services/qualificationMigration/drive.js
243.42KB 244KB
app/drive.(hash).js
233.23KB 234KB
public/pdf.worker.entry.(hash).worker.js
220.57KB 221KB
public/drive.(hash).min.css
85.57KB 86KB
app/drive.(hash).min.css
54.6KB 55KB
vendors/drive.(hash).(hash).min.css
34.38KB 35KB
public/cozy-bar.css
18.42KB 24KB

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@trollepierre trollepierre merged commit acc29f0 into master Sep 2, 2022
@trollepierre trollepierre deleted the fix-search-bar branch September 2, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants