Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Search): prevent duplicate API called when suggestions are fetched #2685

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix(Search): prevent duplicate API called when suggestions are fetched #2685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/drive/web/modules/services/components/SuggestionProvider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { TYPE_DIRECTORY, makeNormalizedFile } from './helpers'
class SuggestionProvider extends React.Component {
componentDidMount() {
const { intent } = this.props
this.hasIndexedFiles = false
this.hasIndexFilesBeenLaunched = false

// re-attach the message listener for the intent to receive the suggestion requests
window.addEventListener('message', event => {
Expand Down Expand Up @@ -39,7 +39,8 @@ class SuggestionProvider extends React.Component {
* @returns {Promise<void>} nothing
*/
async provideSuggestions(query, id, intent) {
if (!this.hasIndexedFiles) {
if (!this.hasIndexFilesBeenLaunched) {
this.hasIndexFilesBeenLaunched = true
await this.indexFiles()
}

Expand Down Expand Up @@ -96,7 +97,6 @@ class SuggestionProvider extends React.Component {
)

this.fuzzyPathSearch = new FuzzyPathSearch(normalizedFiles)
this.hasIndexedFiles = true
}

render() {
Expand Down