Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add InputGroup.Unit #1113

Merged
merged 3 commits into from
Jul 23, 2019
Merged

feat: Add InputGroup.Unit #1113

merged 3 commits into from
Jul 23, 2019

Conversation

ptbrowne
Copy link
Contributor

Make a component for something that we use in several apps.

@ptbrowne ptbrowne requested a review from y-lohse as a code owner July 23, 2019 09:21
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but snapshots should fail

@ptbrowne
Copy link
Contributor Author

LGTM but snapshots should fail

Good catch, the InputGroup examples were not snapshotted. I added them. Snapshot failure will be for next time :)

@Crash--
Copy link
Contributor

Crash-- commented Jul 23, 2019

Thanks

@ptbrowne ptbrowne merged commit d647bf2 into master Jul 23, 2019
@ptbrowne ptbrowne deleted the add-input-group-unit branch July 23, 2019 11:40
@cozy-bot
Copy link

🎉 This PR is included in version 22.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants