Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run autoflake + isort #1279

Merged
merged 5 commits into from
Apr 20, 2024
Merged

chore: run autoflake + isort #1279

merged 5 commits into from
Apr 20, 2024

Conversation

cpacker
Copy link
Owner

@cpacker cpacker commented Apr 20, 2024

# we had a lot of dead imports
# also we shouldn't strip __init__ imports: https://github.com/PyCQA/autoflake/issues/35
# pip install autoflake
autoflake --remove-all-unused-imports --remove-unused-variables --in-place --recursive --ignore-init-module-imports .

# have a consistent import ordering
# pip install isort
isort .

# autoflake broke some black formatting
poetry run black .

We should probably add this to a GitHub action to enforce clean imports / removing stray variables etc.

@cpacker cpacker changed the title chore: run autoflake chore: run autoflake + isort Apr 20, 2024
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarahwooders sarahwooders merged commit eaed123 into main Apr 20, 2024
8 checks passed
@cpacker cpacker deleted the autoflake-cleanup branch May 1, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants