Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update workflows (add autoflake and isort) #1300

Merged
merged 10 commits into from
Apr 27, 2024
Merged

ci: update workflows (add autoflake and isort) #1300

merged 10 commits into from
Apr 27, 2024

Conversation

cpacker
Copy link
Owner

@cpacker cpacker commented Apr 26, 2024

Please describe the purpose of this pull request.

Follow-up to #1279

Developers should now use pre-commit to correctly stage the linters (autoflake -> isort -> black):

# install the `dev` package that has precommit/autoflake/isort/black
poetry install --all-extras

# set up pre-commit to run on all git commits
poetry run pre-commit install

To manually trigger pre-commit:

# wipe cache
poetry run pre-commit clean

# run pre-commit hooks across all files
poetry run pre-commit run --all-files

How to test

See passing workflows.

Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cpacker cpacker merged commit a86374b into main Apr 27, 2024
5 of 7 checks passed
@cpacker cpacker deleted the update-workflows branch April 27, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants