several bug fixes - see CHANGES file

cpan-testers · Dec 14, 2008 · c664da0 · c664da0
1 parent 9baed4a
commit c664da0
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,5 +1,10 @@
 Revision history for Perl module CPAN::Testers::WWW::Reports::Mailer.
 
+0.06	17/11/2008
+	- fixed run time error where iterator call was bogus :(
+	- fixed preferences parsing to correctly set the new fields for ignored
+	  and report.
+
 0.05	16/11/2008
 	- intergrated changes from the preferences site for ignoring 
 	  distributions and selecting the report type.

diff --git a/META.yml b/META.yml
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name:                     CPAN-Testers-WWW-Reports-Mailer
-version:                  0.05
+version:                  0.06
 abstract:                 CPAN Testers Reports Mailer
 author:
   - Barbie <barbie@cpan.org>
@@ -30,10 +30,10 @@ requires:
 provides:
   CPAN::Testers::WWW::Reports::Mailer:
     file:     lib/CPAN/Testers/WWW/Reports/Mailer.pm
-    version:  0.05
+    version:  0.06
   CPAN::Testers::WWW::Reports::Mailer::DBUtils:
     file:     lib/CPAN/Testers/WWW/Reports/Mailer/DBUtils.pm
-    version:  0.05
+    version:  0.06
 
 meta-spec:
    version:   1.4

diff --git a/lib/CPAN/Testers/WWW/Reports/Mailer.pm b/lib/CPAN/Testers/WWW/Reports/Mailer.pm
@@ -4,7 +4,7 @@ use warnings;
 use strict;
 
 use vars qw($VERSION);
-$VERSION = '0.05';
+$VERSION = '0.06';
 
 =head1 NAME
 
@@ -173,7 +173,7 @@ sub check_reports {
     my $rows = $options{cpanstats}->Iterator('hash',$phrasebook{'GetReports'},$last_id);
     return  unless($rows);
 
-    while( my $row = $rows-()) {
+    while( my $row = $rows->()) {
         $counts{REPORTS}++;
         $last_id = $row->{id};
         $row->{state} = uc $row->{state};
@@ -429,6 +429,8 @@ sub get_prefs {
     # use global defaults
     my %prefs = (
             active      => 0,
+            ignored     => 0,
+            report      => 1,
             grades      => {'FAIL' => 1},
             tuple       => 'FIRST',
             version     => 'LATEST',
@@ -447,6 +449,8 @@ sub parse_prefs {
     my %grades = map {$_ => 1} split(',',$row->{grade});
 
     $hash{grades}   = \%grades;
+    $hash{ignored}  = $row->{ignored}   || 0;
+    $hash{report}   = $row->{report}    || 1;
     $hash{tuple}    = $row->{tuple}     || 'FIRST';
     $hash{version}  = $row->{version}   || 'LATEST';
     $hash{patches}  = $row->{patches}   || 0;

diff --git a/lib/CPAN/Testers/WWW/Reports/Mailer/DBUtils.pm b/lib/CPAN/Testers/WWW/Reports/Mailer/DBUtils.pm
@@ -4,7 +4,7 @@ use warnings;
 use strict;
 
 use vars qw($VERSION);
-$VERSION = '0.05';
+$VERSION = '0.06';
 
 =head1 NAME