Use MySQL 5.7 in Travis tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2018 10:08
JSON support is required for the tests to run, and this support was added in MySQL 5.7, however only MySQL 5.6 is available at present on Travis-CI.
In order to ensure that the environment variables are used in the builds for Perl 5.24 and blead, one must define the Perl versions within the `include` section of the `matrix` directive. This ensures that instead of running two builds using Perl 5.24 (one without environment variables, and one with) that only one build with the required environment variables is run.
|
This looks great: The tests are finally passing on Travis! It looks like it's not allowing "blead" to fail anymore, though. Blead runs have too many variables to care much whether they pass/fail, unless they fail consistently (and honestly, I never look, so maybe we should give that up entirely) And we only need the coverage report run once (preferably on 5.24), so |
It's only really necessary to produce the coverage report the once and it makes most sense to do this on a non-blead perl.
|
You're right, it wasn't allowing blead to fail anymore; sorry about that! The recent commit to this branch allows things to work correctly as far as I can tell. At least the requirement that blead is allowed to fail and coverage is only run on the stable Perl version. |
|
Great! Thanks! |
preaction
added a commit
that referenced
this pull request
Aug 24, 2018
[Added]
- Added a `version` argument to release resultsets to filter
per-release summary data by dist _and_version.
- Added classes for the Perl version metadata tables. These classes
allow access to the `perl_version` table which stores metadata
about known Perl 5 releases.
- Added method to search for test summary rows by the Perl maturity
[Fixed]
- Fixed "patch" Perls to be considered "development" Perls. This is
how the existing site and backend treats them, even though the two
flags are different. "Patch" Perls are changed from the official
P5P releases, and should therefore be treated differently.
- Fixed Travis config to use MySQL 5.7. This MySQL version is
required for the tests to run. Thanks @paultcochrane [Github #21]
- Fixed "created" date in test reports being set to impossible
values. We were allowing this to come from reporters, but we want
this to be the time that we got the report. Later, if we want, we
can add another field for when the reporter claims to have created
the report. [Github #19]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests require a MySQL version which supports JSON data structures. This feature is only available from MySQL 5.7, whereas Travis installs version 5.6 by default. The first change in this PR upgrades MySQL up to 5.7 so that the tests can pass. The second change ensures that builds without environment variables aren't run unnecessarily.
This pull request is submitted in the hope that it is useful. If anything needs to be changed, please just let me know and I'll be happy to update as required and resubmit.