-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds workflow_job_seconds metric #5
Commits on Apr 18, 2022
-
* Intention to support instantiation of server for integration testing. Side effect is improving readability. * Extracts root handler into func. * Error logging handled by main.
Configuration menu - View commit details
-
Copy full SHA for 50c0223 - Browse repository at this point
Copy the full SHA 50c0223View commit details -
extract server and related out of main package
* Intention is to test against package interface using server_test package. Couldn't get to work with main_test. * Side effect is improved readability due to less global state. * ghActionsExporter private to package as created in Server setup
Configuration menu - View commit details
-
Copy full SHA for 5b8f493 - Browse repository at this point
Copy the full SHA 5b8f493View commit details -
adds /metrics integration test
* Intention was to improve coverage of http server implementation. * Probably makes more sense to test the handlers directly for most cases.
Configuration menu - View commit details
-
Copy full SHA for 79cab72 - Browse repository at this point
Copy the full SHA 79cab72View commit details -
adds tests for webhook event handler
* Backfills tests before behaviour changes. * CheckRun test only checks for 200 due to async behaviour.
Configuration menu - View commit details
-
Copy full SHA for 8c2fbba - Browse repository at this point
Copy the full SHA 8c2fbbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d804da - Browse repository at this point
Copy the full SHA 0d804daView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5684f7 - Browse repository at this point
Copy the full SHA d5684f7View commit details -
observe queued time from in_progress_event
Assumes job queue time can be calculated from difference between job start time and start time of first step. Labels: * runner_group to identify queues for specific runners * state queued as durations can also be published for completed jobs * no workflow label as it is not possible to identify workflow without additional API calls
Configuration menu - View commit details
-
Copy full SHA for 76275bf - Browse repository at this point
Copy the full SHA 76275bfView commit details -
introduces workflowJobObserver to simplify testing
* Simplifies testing by moving observation of workflow job metrics under interface. * Leaves other metrics untouched for now, even though inconsistent.
Configuration menu - View commit details
-
Copy full SHA for 98dbe95 - Browse repository at this point
Copy the full SHA 98dbe95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93f82a0 - Browse repository at this point
Copy the full SHA 93f82a0View commit details -
adds integration test for workflow job metrics
* Use custom serve mux to allow for creation of multiple servers in integration tests.
Configuration menu - View commit details
-
Copy full SHA for 9769d83 - Browse repository at this point
Copy the full SHA 9769d83View commit details
Commits on Apr 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 170145f - Browse repository at this point
Copy the full SHA 170145fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e9d254 - Browse repository at this point
Copy the full SHA 8e9d254View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd759ad - Browse repository at this point
Copy the full SHA dd759adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5db8e - Browse repository at this point
Copy the full SHA 1f5db8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for eea7d22 - Browse repository at this point
Copy the full SHA eea7d22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37c0c95 - Browse repository at this point
Copy the full SHA 37c0c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for abb1407 - Browse repository at this point
Copy the full SHA abb1407View commit details -
Configuration menu - View commit details
-
Copy full SHA for f51a8ff - Browse repository at this point
Copy the full SHA f51a8ffView commit details -
adds test for negative queue durations
This is possible as it seems step started_at times are rounded to the closest second whereas job started_at time has miliseconds included.
Configuration menu - View commit details
-
Copy full SHA for aee6ace - Browse repository at this point
Copy the full SHA aee6aceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 504a3f2 - Browse repository at this point
Copy the full SHA 504a3f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5528cde - Browse repository at this point
Copy the full SHA 5528cdeView commit details