Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workflow_job_seconds metric #5

Merged
merged 21 commits into from
Apr 20, 2022

Commits on Apr 18, 2022

  1. server to struct

    * Intention to support instantiation of server for
    integration testing. Side effect is improving readability.
    * Extracts root handler into func.
    * Error logging handled by main.
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    50c0223 View commit details
    Browse the repository at this point in the history
  2. extract server and related out of main package

    * Intention is to test against package interface
    using server_test package. Couldn't get to work
    with main_test.
    * Side effect is improved readability due to less
    global state.
    * ghActionsExporter private to package as created
    in Server setup
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5b8f493 View commit details
    Browse the repository at this point in the history
  3. adds /metrics integration test

    * Intention was to improve coverage of http server
    implementation.
    * Probably makes more sense to test the handlers
    directly for most cases.
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    79cab72 View commit details
    Browse the repository at this point in the history
  4. adds tests for webhook event handler

    * Backfills tests before behaviour changes.
    * CheckRun test only checks for 200 due to
    async behaviour.
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8c2fbba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d804da View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d5684f7 View commit details
    Browse the repository at this point in the history
  7. observe queued time from in_progress_event

    Assumes job queue time can be calculated from difference
    between job start time and start time of first step.
    
    Labels:
    * runner_group to identify queues for specific runners
    * state queued as durations can also be published for
      completed jobs
    * no workflow label as it is not possible to identify
      workflow without additional API calls
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    76275bf View commit details
    Browse the repository at this point in the history
  8. introduces workflowJobObserver to simplify testing

    * Simplifies testing by moving observation of workflow job
    metrics under interface.
    * Leaves other metrics untouched for now, even though
    inconsistent.
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    98dbe95 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    93f82a0 View commit details
    Browse the repository at this point in the history
  10. adds integration test for workflow job metrics

    * Use custom serve mux to allow for creation of
    multiple servers in integration tests.
    janakerman committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9769d83 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Configuration menu
    Copy the full SHA
    170145f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e9d254 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd759ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f5db8e View commit details
    Browse the repository at this point in the history
  5. go mod vendor

    janakerman committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    eea7d22 View commit details
    Browse the repository at this point in the history
  6. go mod tidy

    janakerman committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    37c0c95 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    abb1407 View commit details
    Browse the repository at this point in the history
  8. corrects hard coded state

    janakerman committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    f51a8ff View commit details
    Browse the repository at this point in the history
  9. adds test for negative queue durations

    This is possible as it seems step started_at times are
    rounded to the closest second whereas job started_at time
    has miliseconds included.
    janakerman committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    aee6ace View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    504a3f2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5528cde View commit details
    Browse the repository at this point in the history