Skip to content
This repository has been archived by the owner on Nov 26, 2022. It is now read-only.

Use for showing changes #1

Closed
wants to merge 219 commits into from
Closed

Use for showing changes #1

wants to merge 219 commits into from

Conversation

cpb8010
Copy link
Owner

@cpb8010 cpb8010 commented May 6, 2018 •
edited

So only 7 tests fail at this point, and they all appear to be related to the mixins.

` 7 failing

  1. creates a CodeMirror instance when mounted:
    TypeError: Cannot read property '$cm' of undefined
    at Context.it (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\codemirror.spec.js:35:1)

  2. sets content initially with the text property:
    TypeError: Cannot read property '$cm' of undefined
    at Context.it (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\codemirror.spec.js:39:1)

  3. sets options with the options property:
    TypeError: Cannot read property '$cm' of undefined
    at Context.it (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\codemirror.spec.js:43:1)

  4. keeps the text property in sync:
    TypeError: Cannot read property 'text' of undefined
    at Context.it (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\codemirror.spec.js:47:1)

  5. mountTo Vue mixin mounts a Vue component with $mountTo():
    TypeError: this.$mount(...).$appendTo is not a function
    at Vue.$mountTo (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\mixins\mount-to.js:9:1)
    at Context.done (.tmp\mocha-webpack\1525915795720\webpack:\src\vue\mixins\mount-to.spec.js:24:1)

  6. starts with one

    shown:
    TypeError: vm.$el.querySelectorAll is not a function
    at Context.it (.tmp\mocha-webpack\1525915795720\webpack:\src\welcome\index.spec.js:20:1)

  7. shows the matching number of

    s:
    Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
    `

When running the live application none of the functions on Vue exist yet, but I don't know enough about the startup process yet to troubleshoot.

The other thing I need to fix is the event hub usage and location (for replacing $dispatch). It needs to be hooked up to the components that need it.

colin_bellmore and others added 30 commits May 3, 2018 00:35
@cpb8010
1. Replace 'dist/web/**' with 'dist/web/:*+'
1fa8e64 
  Line 14: scripts/build-nw.js
  Reason: The syntax for route matching has changed since Vue Router now uses path-to-regexp under the hood
  More info: http://vuejs.org/guide/migration-vue-router.html#One-or-More-Named-Parameters
@cpb8010
2. Replace sayPlural 'Plural string' with sayPlural('Plural, string')
b1aaa72 
  Line 59: scripts/extract-pot.js
  Reason: Filters with arguments must now use the same syntax as JavaScript functions
  More info: http://vuejs.org/guide/migration.html#Filter-Argument-Syntax
@cpb8010
3. Replace 'src/**/*.html' with 'src/:*+/*.html'
a476c71 
  Line 78: scripts/extract-pot.js
  Reason: The syntax for route matching has changed since Vue Router now uses path-to-regexp under the hood
  More info: http://vuejs.org/guide/migration-vue-router.html#One-or-More-Named-Parameters
@cpb8010
4. Replace 'src/**/*.js' with 'src/:*+/*.js'
f8937b4 
  Line 102: scripts/extract-pot.js
  Reason: The syntax for route matching has changed since Vue Router now uses path-to-regexp under the hood
  More info: http://vuejs.org/guide/migration-vue-router.html#One-or-More-Named-Parameters
@cpb8010
5. Replace ready with mounted, then use Vue.nextTick if you need an i…
be8b764 
…n-document guarantee

  Line 13: src/common/app/index.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
6. Replace "src/**/*.spec.js\" with "src/:*+/*.spec.js\"
6b18271 
  Line 29: package.json
  Reason: The syntax for route matching has changed since Vue Router now uses path-to-regexp under the hood
  More info: http://vuejs.org/guide/migration-vue-router.html#One-or-More-Named-Parameters
@cpb8010
7. Replace "vue": "^1.0.18" with "vue": "^2.0.0", then run: npm install
affff6c 
  Line 55: package.json
  Reason: If you are using pre-2.0 Vue through NPM, you have to update it in your package.json file
  More info: http://vuejs.org/guide/migration.html#
@cpb8010
8. Replace "vue-router": "^0.7.13" with "vue-router": "^2.0.0", then …
f23c08d 
…run: npm install

  Line 56: package.json
  Reason: If you are using pre-2.0 Vue Router through NPM, you have to update it in your package.json file
  More info: http://vuejs.org/guide/migration-vue-router.html#
@cpb8010
9. Replace ready with mounted, then use Vue.nextTick if you need an i…
0d21c68 
…n-document guarantee

  Line 69: src/common/router.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
10. Replace ready with mounted, then use Vue.nextTick if you need an …
dba7ec2 
…in-document guarantee

  Line 92: src/common/router.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
11. Replace ready with mounted, then use Vue.nextTick if you need an …
c4e315d 
…in-document guarantee

  Line 115: src/common/router.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
12. Replace ready with mounted, then use Vue.nextTick if you need an …
0210bc0 
…in-document guarantee

  Line 139: src/common/router.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
13. Replace {{{ 'This application is released under the \x3ca href="h…
9c3d23d 
…ttp:\/\/www.gnu.org/licenses/gpl-3.0.html">GPL v3\x3c/a> license, but any work created with it may be released under any terms, including commercial ones.'| say }}} with v-html="'This application is released under the \x3ca href="http:\/\/www.gnu.org/licenses/gpl-3.0.html">GPL v3\x3c/a> license, but any work created with it may be released under any terms, including commercial ones.'| say" on a containing element

  Line 9: src/dialogs/about/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
14. Replace {{{ 'Source Sans Pro and Source Code Pro were designed by…
30271a1 
… Paul D. Hunt under the guidance of Robert Slimbach for \x3ca href="http:\/\/adobe.com/">Adobe\x3c/a>\x3cbr> Nunito was designed by \x3ca href="http:\/\/code.newtypography.co.uk/">Vernon Adams\x3c/a>'| say }}} with v-html="'Source Sans Pro and Source Code Pro were designed by Paul D. Hunt under the guidance of Robert Slimbach for \x3ca href="http:\/\/adobe.com/">Adobe\x3c/a>\x3cbr> Nunito was designed by \x3ca href="http:\/\/code.newtypography.co.uk/">Vernon Adams\x3c/a>'| say" on a containing element

  Line 102: src/dialogs/about/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
15. Update v-ref:modal to ref="modal"
6ff4854 
  Line 1: src/dialogs/app-donation/index.html
  Reason: v-el and v-ref merged into ref attribute
  More info: http://vuejs.org/guide/migration.html#v-el-and-v-ref
@cpb8010
16. Replace {{{ "If you love Twine as much as I do, please consider h…
88c3b9a 
…elping it grow with a donation. Twine is an open source project that will always be free to use — and with your help, Twine will continue to thrive." | say }}} with v-html=""If you love Twine as much as I do, please consider helping it grow with a donation. Twine is an open source project that will always be free to use — and with your help, Twine will continue to thrive." | say" on a containing element

  Line 5: src/dialogs/app-donation/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
17. Replace {{{ "This message will only be shown to you once.<br&g…
e1c4b5d 
…t;If you'd like to donate to Twine development in the future, you can do so at <a href=\"http:\/\/twinery.org/donate\" target=\"_blank\">http://twinery.org/donate</a>." | say }}} with v-html=""This message will only be shown to you once.<br>If you'd like to donate to Twine development in the future, you can do so at <a href=\"http:\/\/twinery.org/donate\" target=\"_blank\">http://twinery.org/donate</a>." | say" on a containing element

  Line 22: src/dialogs/app-donation/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
18. Replace {{{message}}} with v-html="message" on a containing element
e7349c6 
  Line 2: src/dialogs/confirm/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
19. Replace {{{cancelLabel}}} with v-html="cancelLabel" on a containi…
a91cc64 
…ng element

  Line 4: src/dialogs/confirm/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
20. Replace {{{buttonLabel}}} with v-html="buttonLabel" on a containi…
571839b 
…ng element

  Line 5: src/dialogs/confirm/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
21. Replace {{{coda}}} with v-html="coda" on a containing element
a88134c 
  Line 7: src/dialogs/confirm/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
22. Replace this.$broadcast('close', true) to use a global event bus …
37d9760 
…or vuex (see link below for implementation details)

  Line 40: src/dialogs/confirm/index.js
  Reason: $dispatch and $broadcast have been removed because the pattern doesn't scale well
  More info: http://vuejs.org/guide/migration.html#dispatch-and-broadcast
@cpb8010
23. Replace this.$broadcast('close', false) to use a global event bus…
7cc88ed 
… or vuex (see link below for implementation details)

  Line 44: src/dialogs/confirm/index.js
  Reason: $dispatch and $broadcast have been removed because the pattern doesn't scale well
  More info: http://vuejs.org/guide/migration.html#dispatch-and-broadcast
@cpb8010
24. Update v-ref:tabs to ref="tabs"
4eb6f15 
  Line 3: src/dialogs/formats/index.html
  Reason: v-el and v-ref merged into ref attribute
  More info: http://vuejs.org/guide/migration.html#v-el-and-v-ref
@cpb8010
25. Replace transition="fade-in-out" attribute with either a <transit…
f0dca2a 
…ion name="fade-in-out"> or <transition-group name="fade-in-out"> wrapper component

  Line 22: src/dialogs/formats/index.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
26. Replace transition="fade-in-out" attribute with either a <transit…
b6ce113 
…ion name="fade-in-out"> or <transition-group name="fade-in-out"> wrapper component

  Line 41: src/dialogs/formats/index.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
27. Replace {{{ error }}} with v-html="error" on a containing element
62744c5 
  Line 69: src/dialogs/formats/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation
@cpb8010
28. Replace ready with mounted, then use Vue.nextTick if you need an …
b1e2b08 
…in-document guarantee

  Line 128: src/dialogs/formats/index.js
  Reason: ready lifecycle hook has been removed
  More info: http://vuejs.org/guide/migration.html#ready
@cpb8010
29. Update title="{{ 'Set this format as default for stories' | say }…
f17950d 
…}" to v-bind:title="'Set this format as default for stories' | say"

  Line 3: src/dialogs/formats/item.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes
@cpb8010
30. Update for="{{format.name}}-{{format.properties.version}}" to use…
aafd3ae 
… v-bind with a computed property

  Line 8: src/dialogs/formats/item.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes
cpb8010 added 27 commits May 6, 2018 13:46
@cpb8010
38. Replace filtered value in v-html="'If you've never used Twine bef…
f6b300b 
…ore, then welcome! The Twine 2 Guide and the official wiki in general, are a great place to learn. Keep in mind that some articles on the wiki at large were written for Twine 1, which is a little bit different than this version. But most of the concepts are the same.' | say" with a method or computed property

  Line 23: src/nw/patches/welcome-view/replacement-template.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

39. Replace filtered value in v-html="'You can also get help over at the Twine forum, too.' | say" with a method or computed property
  Line 26: src/nw/patches/welcome-view/replacement-template.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

40. Replace filtered value in v-html="'If you have used Twine 1 before, the guide also has details on what has changed in this version. Chief among them is a new default story format, Harlowe. But if you find you prefer the Twine 1 scripting syntax, try using SugarCube instead.' | say" with a method or computed property
  Line 28: src/nw/patches/welcome-view/replacement-template.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
42. Replace transition="grow-in-out" attribute with either a <transit…
eb272ad 
…ion name="grow-in-out"> or <transition-group name="grow-in-out"> wrapper component

  Line 6: src/story-edit-view/index.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
43. Update track-by="startIndex" to v-bind:key="start.startIndex"
ef9d102 
  Line 22: src/story-edit-view/link-arrows/index.html
  Reason: track-by has been replaced by the key attribute, which conforms with language used by other libraries and behaves the same as other attributes
  More info: http://vuejs.org/guide/migration.html#track-by

44. Update track-by="endIndex" to v-bind:key="end.endIndex"
  Line 23: src/story-edit-view/link-arrows/index.html
  Reason: track-by has been replaced by the key attribute, which conforms with language used by other libraries and behaves the same as other attributes
  More info: http://vuejs.org/guide/migration.html#track-by
@cpb8010
45. Replace {{{ 'Delete &ldquo;%s&rdquo;' | say(passage.name) }}} wit…
3d649b1 
…h v-html="'Delete &ldquo;%s&rdquo;' | say(passage.name)" on a containing element

  Line 3: src/story-edit-view/passage-item/passage-menu/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation

46. Replace {{{ 'Edit &ldquo;%s&rdquo;' | say(passage.name) }}} with v-html="'Edit &ldquo;%s&rdquo;' | say(passage.name)" on a containing element
  Line 8: src/story-edit-view/passage-item/passage-menu/index.html
  Reason: HTML interpolation with {{{ }}} has been removed
  More info: http://vuejs.org/guide/migration.html#HTML-Interpolation

47. Replace filtered value in v-bind:title="'Test story starting here' | say" with a method or computed property
  Line 12: src/story-edit-view/passage-item/passage-menu/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

48. Replace filtered value in v-bind:title="'More passage options' | say" with a method or computed property
  Line 16: src/story-edit-view/passage-item/passage-menu/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
49. Replace filtered value in v-bind:title="'Go to the story list' | …
be5565c 
…say" with a method or computed property

  Line 3: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

50. Replace filtered value in v-bind:title="'Show only story structure' | say" with a method or computed property
  Line 16: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

51. Replace filtered value in v-bind:title="'Show only passage titles' | say" with a method or computed property
  Line 20: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

52. Replace filtered value in v-bind:title="'Show passage titles and excerpts' | say" with a method or computed property
  Line 24: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

53. Replace filtered value in v-bind:title="'Play this story in test mode' | say" with a method or computed property
  Line 29: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

54. Replace filtered value in v-bind:title="'Play this story' | say" with a method or computed property
  Line 35: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

55. Replace filtered value in v-bind:title="'Add a new passage' | say" with a method or computed property
  Line 41: src/story-edit-view/story-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
56. Replace filtered value in v-bind:placeholder="'Quick Find' | say"…
e40f930 
… with a method or computed property

  Line 2: src/story-edit-view/story-toolbar/story-search/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

57. Replace filtered value in v-bind:title="'Find and replace across the entire story' | say" with a method or computed property
  Line 3: src/story-edit-view/story-toolbar/story-search/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
58. Update title="{{ 'Last changed date' | say }}" to v-bind:title="'…
d2c8599 
…Last changed date' | say"

  Line 13: src/story-list-view/index.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes

59. Update title="{{ 'Story name' | say }}" to v-bind:title="'Story name' | say"
  Line 19: src/story-list-view/index.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes

60. Replace transition="grow-in-out" attribute with either a <transition name="grow-in-out"> or <transition-group name="grow-in-out"> wrapper component
  Line 32: src/story-list-view/index.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute58. Update title="{{ 'Last changed date' | say }}" to v-bind:title="'Last changed date' | say"
  Line 13: src/story-list-view/index.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes

59. Update title="{{ 'Story name' | say }}" to v-bind:title="'Story name' | say"
  Line 19: src/story-list-view/index.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes

60. Replace transition="grow-in-out" attribute with either a <transition name="grow-in-out"> or <transition-group name="grow-in-out"> wrapper component
  Line 32: src/story-list-view/index.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
61. Replace filtered value in v-bind:title="'Create a brand-new story…
9733011 
…' | say" with a method or computed property

  Line 6: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

62. Replace filtered value in v-bind:title="'Import a published story or Twine archive' | say" with a method or computed property
  Line 11: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

63. Replace filtered value in v-bind:title="'Save all stories to a Twine archive file' | say" with a method or computed property
  Line 16: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

64. Replace filtered value in v-bind:title="'Work with story and proofing formats' | say" with a method or computed property
  Line 21: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

65. Replace filtered value in v-bind:title="'Change the language Twine uses' | say" with a method or computed property
  Line 26: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

66. Replace filtered value in v-bind:title="'Browse online help' | say" with a method or computed property
  Line 31: src/story-list-view/list-toolbar/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
67. Update title="{{ 'Use light theme' | say }}" to v-bind:title="'Us…
8317c9f 
…e light theme' | say"

  Line 2: src/story-list-view/list-toolbar/theme-switcher.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes

68. Update title="{{ 'Use dark theme' | say }}" to v-bind:title="'Use dark theme' | say"
  Line 5: src/story-list-view/list-toolbar/theme-switcher.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes
@cpb8010
69. Replace transition="fade-in-out" attribute with either a <transit…
ca43a42 
…ion name="fade-in-out"> or <transition-group name="fade-in-out"> wrapper component

  Line 2: src/ui/notify/list.html
  Reason: The new and improved transition system requires use of new <transition> and <transition-group> components
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
71. Replace .fade-in-out-transition with .fade-in-out-enter-active, .…
5c4c648 
…fade-in-out-leave-active

  Line 1: src/vue/transitions.less
  Reason: v-transition class has been replaced by the standard classes used by Angular and React CSSTransitionGroup
  More info: http://vuejs.org/guide/migration.html#transition-Attribute

72. Replace .rise-in-out-transition with .rise-in-out-enter-active, .rise-in-out-leave-active
  Line 10: src/vue/transitions.less
  Reason: v-transition class has been replaced by the standard classes used by Angular and React CSSTransitionGroup
  More info: http://vuejs.org/guide/migration.html#transition-Attribute
@cpb8010
73. Replace filtered value in v-html="'If you've never used Twine bef…
8aa23fa 
…ore, then welcome! The Twine 2 Guide and the official wiki in general, are a great place to learn. Keep in mind that some articles on the wiki at larger were written for Twine 1, which is a little bit different than this version. But most of the concepts are the same.' | say" with a method or computed property

  Line 25: src/welcome/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

74. Replace filtered value in v-html="'You can also get help over at the Twine forum, too.' | say" with a method or computed property
  Line 27: src/welcome/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

75. Replace filtered value in v-html="'If you have used Twine 1 before, the guide also has details on what has changed in this version. Chief among them is a new default story format, Harlowe. But if you find you prefer the Twine 1 scripting syntax, try using SugarCube instead.' | say" with a method or computed property
  Line 29: src/welcome/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

76. Replace filtered value in v-html="'That means you don't need to create an account to use Twine 2, and everything you create isn't stored on a server somewhere else &mdash; it stays right in your browser.' | say" with a method or computed property
  Line 43: src/welcome/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations

77. Replace filtered value in v-html="'Secondly, &lt;b&gt;anyone who can use this browser can see and make changes to your work&lt;/b&gt;. So if you've got a nosy kid brother, look into setting up a separate profile for yourself.' | say" with a method or computed property
  Line 47: src/welcome/index.html
  Reason: Filters can now only be used inside text interpolations, e.g. {{ date | formatDate('YY-MM-DD') }}
  More info: http://vuejs.org/guide/migration.html#Filters-Outside-Text-Interpolations
@cpb8010
pass 3
7cc684a 
still need to fix:
- eventHub usage and location
- html in translations
- locale import location
@cpb8010
1. Update track-by="index" to v-bind:key="format.index"
4fd1474 
  Line 23: src/dialogs/formats/index.html
  Reason: track-by has been replaced by the key attribute, which conforms with language used by other libraries and behaves the same as other attributes
  More info: http://vuejs.org/guide/migration.html#track-by

2. Update track-by="index" to v-bind:key="format.index"
  Line 44: src/dialogs/formats/index.html
  Reason: track-by has been replaced by the key attribute, which conforms with language used by other libraries and behaves the same as other attributes
  More info: http://vuejs.org/guide/migration.html#track-by

3. Update id="{{format.name}}-{{format.properties.version}}" to use v-bind with a computed property
  Line 3: src/dialogs/formats/item.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes
@cpb8010
4. Update track-by="index" to v-bind:key="format.index"
1d6f068 
  Line 17: src/dialogs/story-format/index.html
  Reason: track-by has been replaced by the key attribute, which conforms with language used by other libraries and behaves the same as other attributes
  More info: http://vuejs.org/guide/migration.html#track-by
@cpb8010
5. Update v-el:new-name to ref="newName"
d05e444 
  Line 22: src/editors/passage/tag-editor/index.html
  Reason: v-el and v-ref merged into ref attribute
  More info: http://vuejs.org/guide/migration.html#v-el-and-v-ref
@cpb8010
21. Replace v-link="'/stories'" with the new <router-link> component …
56f5fd5 
…(see link below for details)

  Line 3: src/story-edit-view/story-toolbar/index.html
  Reason: The v-link directive has been replaced with the new <router-link> component
  More info: http://vuejs.org/guide/migration-vue-router.html#v-link
@cpb8010
1. Update id="{{format.name}}-{{format.properties.version}}" to use v…
bcf8e34 
…-bind with a computed property

  Line 3: src/dialogs/formats/item.html
  Reason: Interpolation within attributes has been removed
  More info: http://vuejs.org/guide/migration.html#Interpolation-within-Attributes
@cpb8010
Migrate syntax complete
bbf54d3
@cpb8010
Revert router change
9b8bb2f 
The routing has nothing to fo with mocha, i assume the path globbing in mocha is the same
@cpb8010
Revert routing path
1d15dc4 
nw doesn't use vue router for path names hopefully
@cpb8010
Revert "3. Replace 'src/**/*.html' with 'src/:*+/*.html'"
76036df 
This reverts commit a476c71.
@cpb8010
Revert "4. Replace 'src/**/*.js' with 'src/:*+/*.js'"
f94737a 
This reverts commit f8937b4.
@cpb8010
Small fixes from manual review
b77a5d8
@cpb8010
Partial styline undo
0a4dfea 
still need to fix welcome template (which has duplicated text?)
@cpb8010
Remove duplicate text
4ddad9d 
left over from styline
@cpb8010
Fix require paths
fcbba6f 
These are really difficult because of the nesting
@cpb8010 cpb8010 mentioned this pull request May 10, 2018
Closed
@cpb8010 cpb8010 closed this May 30, 2018
@cpb8010 cpb8010 deleted the tx-pass3 branch May 30, 2018 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cpb8010