Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The background color of the diff viewer is black on Windows with Dark Fusion theme #519

Closed
ouuan opened this issue Jul 23, 2020 · 3 comments · Fixed by #520
Closed

The background color of the diff viewer is black on Windows with Dark Fusion theme #519

ouuan opened this issue Jul 23, 2020 · 3 comments · Fixed by #520
Assignees
@ouuan
Labels
bug Something isn't working high_priority High Priority Issues are marked with this label.

Comments

@ouuan
Copy link
Member

ouuan commented Jul 23, 2020

Describe the bug

The background color of the diff viewer is black on Windows with Dark Fusion theme.

To Reproduce

Open the diff viewer.

Screenshots

image

Environment

  • OS: Windows 10
  • CP Editor Version: 6.6.2

Additional context

The palette is set to white Base:

cpeditor/src/Widgets/DiffViewer.cpp

Lines 103 to 108 in 3904ce2

QPalette p = outputEdit->palette();
p.setColor(QPalette::Base, Qt::white); // for system dark theme
p.setColor(QPalette::Text, Qt::black);
outputEdit->setPalette(p);
outputEdit->setHtml(outputHTML);
expectedEdit->setPalette(p);

The background color is white on Arch Linux with KDE with both Dark Breeze and Dark Fusion.

We can use HTML style instead of palette as a workaround.
@ouuan ouuan added bug Something isn't working high_priority High Priority Issues are marked with this label. labels Jul 23, 2020
@ouuan ouuan self-assigned this Jul 23, 2020
ouuan added a commit that referenced this issue Jul 23, 2020
@ouuan
fix(DiffViewer): fix background color with Dark Fusion on Windows
9b801ed 
This fixes #519.

Although the palette was set and it was working on Arch Linux with KDE
with both Dark Breeze and Dark Fusion, the background is black on
Windows with the Dark Fusion theme.

Using HTML style instead of palette can be a workaround.
@ouuan ouuan mentioned this issue Jul 23, 2020
Merged
2 tasks
ouuan added a commit that referenced this issue Jul 23, 2020
@ouuan
fix(DiffViewer): fix background color with Dark Fusion on Windows (#520)
0319aa2 
* fix(DiffViewer): fix background color with Dark Fusion on Windows

This fixes #519.

Although the palette was set and it was working on Arch Linux with KDE
with both Dark Breeze and Dark Fusion, the background is black on
Windows with the Dark Fusion theme.

Using HTML style instead of palette can be a workaround.

* docs(CHANGELOG): update changelog
@ouuan
Copy link
Member Author

ouuan commented Jul 24, 2020

As it's not very critical, we can merge #520 into master after the next release.

@ouuan ouuan closed this as completed Jul 24, 2020
@Shashikant-alt
Copy link

Screenshot from 2021-06-03 20-32-54

The visibility is very low in solarised dark theme. Please tell me how to fix this.

@coder3101
Copy link
Member

Screenshot from 2021-06-03 20-32-54

The visibility is very low in solarised dark theme. Please tell me how to fix this.

Duplicate of #533 in #581 it should be fixed (we are adding option to disable current line highlighting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouuan ouuan

Labels
bug Something isn't working high_priority High Priority Issues are marked with this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(DiffViewer): fix background color with Dark Fusion on Windows cpeditor/cpeditor
3 participants
@coder3101 @ouuan @Shashikant-alt