Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option Check On Testcases With Empty Output #430

Merged
merged 11 commits into from
Jun 20, 2020
Merged

feat: Add option Check On Testcases With Empty Output #430

merged 11 commits into from
Jun 20, 2020

Conversation

tb148
Copy link
Contributor

@tb148 tb148 commented Jun 20, 2020

Add an option to check answers on testcases with empty outputs.

Description

Related Issue

Fix #208.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Type of changes

  • Bug fix (changes which fix an issue)
  • New feature (changes which add functionality)
  • Documentation (changes which modify the documentation only)
  • Style change (changes which do not affect the meaning of the code: code formatting, etc.)
  • Refactor (changes which affect the meaning of the code but neither fix a bug nor add a feature)
  • Performance improve (changes which improve performance)
  • Test (changes which add tests)
  • Build (Changes that affect the build system or external dependencies)
  • CI (changes to CI configuration files and scripts)
  • Chore (changes which do not belong to any type above)
  • Revert (revert previous changes)

Checklist

  • I have read the CONTRIBUTING document.
  • I have tested these changes locally, and this fixes the bug/the new feature behaves as the expectation.
  • The settings file in the old version can be used in the new version after this change.
  • These changes only fix a single bug/introduces a single feature. (Otherwise, open multiple Pull Requests instead, unless these bugs/features are closely related.)
  • The commit messages are clear and detailed. (Otherwise, use git reset and commit again, or use git rebase -i and git commit --amend to modify the commit messages.)
  • These changes don't remove an existing feature. (Otherwise, add an option to disable this feature instead, unless it's necessary to remove this feature.)
  • If there are changes of the text displayed in the UI, I have wrapped them in tr() or QCoreApplication::translate().
  • I have documented these changes in CHANGELOG.md, or these changes are not notable.

@ouuan
Copy link
Member

ouuan commented Jun 20, 2020

You can enable GitHub Actions in your repository so that your codes can be formatted automatically.

However, it's better to format locally, and you can enable "format on save" in your IDE (if it's supported).

@coder3101
Copy link
Member

coder3101 commented Jun 20, 2020

Or by running this script on bash. You may need to install clang-format. (LLVM on Windows)

@tb148
Copy link
Contributor Author

tb148 commented Jun 20, 2020

The translation of this option isn't created yet. You can ask me to add it if you want.

@coder3101
Copy link
Member

Required Steps:

  • Complete checklist of the PR (Contribution.md doc must be agreed to)

  • Add your change to changelog file in doc/CHANGELOG.md under Unreleased, under Added subsection.

Optional Steps:

  • If you can you should add translation for Chinese language.

@tb148 tb148 marked this pull request as draft June 20, 2020 10:58
src/Settings/settings.json Outdated Show resolved Hide resolved
@tb148 tb148 marked this pull request as ready for review June 20, 2020 13:09
Copy link
Member

@ouuan ouuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tools/updateTranslation.sh again.

translations/zh_CN.ts Outdated Show resolved Hide resolved
translations/zh_CN.ts Outdated Show resolved Hide resolved
Tony Brown and others added 4 commits June 20, 2020 21:25
Co-authored-by: Yufan You <ouuansteve@gmail.com>
Co-authored-by: Yufan You <ouuansteve@gmail.com>
@tb148
Copy link
Contributor Author

tb148 commented Jun 20, 2020

Did you make this change manually without running tools/updateTranslation.sh?

Yes, because somehow it doesn't works on my computer (Windows 10)

Copy link
Member

@ouuan ouuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@ouuan
Copy link
Member

ouuan commented Jun 20, 2020

Yes, because somehow it doesn't works on my computer (Windows 10)

Maybe you can run it by git bash (haven't tested yet).

@ouuan ouuan merged commit 6b0e5bf into cpeditor:master Jun 20, 2020
@ouuan
Copy link
Member

ouuan commented Jun 20, 2020

@allcontributors add @tb148 as a contributor for codes.

@allcontributors
Copy link
Contributor

@ouuan

I've put up a pull request to add @tb148! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checker return no verdict when Expected Output is empty
3 participants