Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Settings): add settings of loading external file changes #486

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Jul 7, 2020

Description

Two settings are added:

  • Auto-load external file changes if there's no unsaved modification.
  • Ask whether to load external file changes.

Related Issue

Part of #269.

How Has This Been Tested?

On Arch Linux with four possible settings combination.

@ouuan ouuan requested review from coder3101 and neko-para July 7, 2020 14:18
@pull-assistant
Copy link

pull-assistant bot commented Jul 7, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat(Settings): add settings of loading external file changes

     docs(CHANGELOG): update changelog

Powered by Pull Assistant. Last update 566ecb9 ... 96357a4. Read the comment docs.

Copy link
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can't test on mobile.

@ouuan ouuan merged commit 46ba262 into master Jul 7, 2020
@ouuan ouuan deleted the external-file-change branch July 7, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants