-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Russian translations #494
Conversation
You don't need to use "bak" as we are using git for version control. |
Can you add warnings saying the documents are translated from the English version and might be not up-to-date at the top of the documents? |
I can't push to your branch, have you checked "allow edits from the maintainer"? However, you can apply this patch: diff --git a/src/Settings/settings.json b/src/Settings/settings.json
index e6ce769..0c45d89 100644
--- a/src/Settings/settings.json
+++ b/src/Settings/settings.json
@@ -818,7 +818,7 @@
"type": "QString",
"ui": "QComboBox",
"default": "system",
- "param": "QStringList { \"system\", \"English\", \"简体中文\" }",
+ "param": "QStringList { \"system\", \"English\", \"Русский\", \"简体中文\" }",
"tip": "The language displayed in the UI."
},
{ |
There are many warnings in Qt Linguist, you'd better resolve them. |
@IZOBRETATEL777 Solution for this: Or You can check "Allow edits by Maintainers" (found in the right side of this PR page). So we could solve all your warnings or issues. |
Suggestion applied Co-authored-by: Yufan You <ouuansteve@gmail.com>
Co-authored-by: Yufan You <ouuansteve@gmail.com>
Added warnings saying the documents are translated from the English version and might be not up-to-date at the top of the documents
Patch applied
All done
Applied
|
One more things, please add to |
After you add this to changelog, I will approve the PR and when ouuan approves, he will merge it. Thanks for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Are you always editing the translation file with Qt Linguist? There are many unescaped characters, and some of them even affects the result like this one: (there's an extra You should use Qt Linguist to edit the translations, check all translations again. (I did this (double-check) with the Chinese translation before.) And there are merge conflicts, you should resolve them. |
I use VS code + Vine because it is comfortable for me. OK, for the last translation I used Qt Linguist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget #494 (comment).
Co-authored-by: Yufan You <ouuansteve@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you completely check all translations again. It seems that @IZOBRETATEL777 did most translations, so I think it's better to let @Sadykhzadeh to check.
We communicate with each other and translate the file together, so when someone gives a request for verification, it means that we both fully verified the translation😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems OK. We can fix errors in the future if there are any.
I think we can invite you to our organization, so that if you have time, you can add new translations in corresponding PRs. |
Full translation into Russian
Description
All posible words were translated. Also documetation was updated for Russian translate.
Related Issue
No translation
Motivation and Context
To increase the community of CP Editor
How Has This Been Tested?
Compiled from source code
Ubuntu 18.04 LTS (Mate)
Screenshots (if appropriate)
Type of changes
Checklist
git reset
and commit again, or usegit rebase -i
andgit commit --amend
to modify the commit messages.)tr()
orQCoreApplication::translate()
.