This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add new plug option: :repo #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the plug, support a `:repo` option that when used will override the default repo from the configuration. This can be used in applications that use different repos (databases) in different controller actions.
|
👋 Hey! I'm sorry for the lack of movement on this. I shouldn't have left this for so long without a reply. I am not currently writing Elixir at all, and therefore, I think it would be irresponsible of me to review PRs on this project. I just kept putting off reviewing the issues/PRs on this repo until I started writing Elixir again, but never got around to it. That is my mistake, and I'm really sorry about that 🙏. You put in the time to make this PR, and you deserve a response at the very least. I've marked the project as "not being actively maintained" in the readme. Please feel free to fork it with a different name and put it up on hex with current fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the plug, support a
:repooption that when used will override the default repo from the configuration.This can be used in applications that have different repos (databases) for different controllers / actions.
In my case the application has a primary and a replica MySQL database. Read actions go to the replica and write actions go to the primary. We could have configured canary just to use the primary, but that would put extra reads on the primary that ideally we would avoid.
Also there was a problem during testing because each Repo is sandboxed, so the test would create records in the replica database for testing. But, when we added canary for authorization (configured to use the primary repo), the tests failed because the primary repo sandbox did not contain the records.