Removed depreciated object embeds (w/working tests) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but can we do two things first? Can you remove the old commented out lines from the tests? No need to keep them around as commented since they can easily be retrieved through the git history if needed in the future. Also, can you git squash these two commits into a single commit containing the lib code changes and the associated test changes in the same commit? It allows the git history to remain a bit cleaner. Thanks so much for the work on this. |
|
Okay will do. I will get those resolved later today. |
Removed depreciated object embeds from tests Removed extra comment lines from tests
|
Everything should be resolved down to one commit now. 😄 |
cpjolicoeur
added a commit
that referenced
this pull request
Jan 11, 2016
Removed depreciated object embeds (w/working tests)
|
Glad I could help. 😄 |
|
v 1.2.0 of the gem pushed to rubygems. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed depreciated object embeds. Both YouTube and Vimeo have deprecated object embeds imbeds in favor simpler all in one iframe "universal players."
https://developer.vimeo.com/player/embedding
https://developers.google.com/youtube/player_parameters?hl=en