-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.1: strlen() expects parameter 1 to be string, integer given #200
Comments
I don't think that's what we actually want. I think we should fix the caller so it only calls this method with the correct types. |
A formal change log is provided at https://github.com/cpliakas/git-wrapper/blob/master/upgrade/rector/git-wrapper-30.yaml. |
Actually, there does seem to a bug here, with this. I think the return type of this method is also wrong... |
Does #201 fix your issue? |
#201 fixes the issue indeed, thanks for looking into this so quickly! |
Hi!
I just attempted upgrading from version 2.2.0 to 3.0.1 (an up-to-date changelog would handy btw, but no pressure 😉) and I ran into this error:
This happened when calling the
log
method on aGitWorkingCopy
instance:It interprets
xxx
in the argument-n xxx
as an integer and callingstrlen
on an integer throws the above error. Probably due tostrict_types
being enabled.Suggested would be to change:
to
Does this make sense?
Thanks!
The text was updated successfully, but these errors were encountered: