Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on nette #203

Closed
wants to merge 4 commits into from

Conversation

samdark
Copy link
Contributor

@samdark samdark commented Feb 3, 2020

Fixes #202

@TomasVotruba
Copy link
Contributor

Why this change? The issue was named "nette/utils should be required". What did you meant by that?

preg_ is super hard to read - you need to learn extra constants - and error prone.

@samdark
Copy link
Contributor Author

samdark commented Feb 4, 2020

@TomasVotruba that was suggested by @GrahamCampbell and I liked the idea of less dependencies. If you don't like it, feel free to add nette to require instead.

@TomasVotruba
Copy link
Contributor

TomasVotruba commented Feb 4, 2020

It's important to look at gains + losses, not just gains. Less dependencies !== more sustainable code for the the future.

It's just duplicated code with PHP-vendor lock now, I don't see much value in it.

If you don't like it, feel free to add nette to require instead.

👍

@samdark samdark closed this Feb 4, 2020
@samdark samdark deleted the do-not-depend-on-nette branch February 4, 2020 08:23
@samdark
Copy link
Contributor Author

samdark commented Feb 4, 2020

#204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nette/utils should be required
2 participants