-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2071R2 Named universal character escapes #5368
Conversation
Pending plenary approval, of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to [cpp.predefined] is missing.
I'm totally fine if you don't want to continue working on this, in which case I'm going to take it over; thanks for the submission regardless.
Also, please rebase on HEAD, squash the fixes, and force-push. Thanks. |
I'd like to complete this. It seems like a useful skill to learn for the committee and an additional way to contribute. Although I understand I may be making additional work for reviewers while I'm learning. I'll push all the requested updates to this soon, rebased against current HEAD. |
4d62c07
to
6fb0dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next round.
Feel free to squash and force-push.
Please also clean up the commit description; it should just be
P2071R2 Named universal character escapes
All the incremental updates done during this conversation are not relevant long-term.
739a384
to
b0fabc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's progress. One issue remains.
7e6c8fb
to
79cb4c9
Compare
I apologize for the extra work. Let me know if there's more to do. |
Thanks for looking after this. This looks good to me now. |
Wording for the paper P2071R2 Named universal character escapes, actually an alternate form of universal-character-name, as reviewed and approved by CWG. Not yet approved by plenary.
79cb4c9
to
54ddfb1
Compare
Thanks, we're through. I'm not going to "Approve" this before the plenary motion for fear of someone accidentally merging this. |
Thank you so much for doing this work, I'm very sorry we didn't keep track of it better! |
I'll remember to flag something on the editorial reflector next time.
Unfortunately I was on vacation the week after plenary.
…On Fri, Aug 5, 2022, 18:15 Thomas Köppe ***@***.***> wrote:
Closed #5368 <#5368>.
—
Reply to this email directly, view it on GitHub
<#5368 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5RQSTHZ4YGVVFYP2MTVXWHBFANCNFSM5RV4NNQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The wording as approved by CWG for P2071, including the control code alias table which would be tedious to reproduce. Uses a new code font macro for uname to clarify there is no internal invisible whitespace.
Fixes cplusplus/papers#798