-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update most package versions #190
Conversation
extent build_all.py to inject cmake modules and use Ninja generator
use SYSTEM include paths (for clang++) we should not use local installed header!
finalize cmake project code injection as an option
gtest needs c++17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the issue and PR! It was about time to give the examples some love and update the dependencies to recent versions.
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
indent with only 2 spaces again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the formatting! I'd still like the above issues to be addressed before merging.
As for the apparently system-dependent issues appearing on your setup, could you check if they still arise if you don't use |
the gtest build error seems to be a make -j cpucount problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the PR and updates!
fix examples with build problems too
see #189
add
cmake project code injection
as an option when usingbuild_all.py
see https://cmake.org/cmake/help/latest/command/project.html#code-injection
tested with Apple clang version 12.0.0 (clang-1200.0.32.29)