Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update most package versions #190

Merged
merged 8 commits into from
Feb 7, 2021
Merged

Conversation

ClausKlein
Copy link
Contributor

@ClausKlein ClausKlein commented Feb 4, 2021

fix examples with build problems too

see #189

add cmake project code injection as an option when using build_all.py

see https://cmake.org/cmake/help/latest/command/project.html#code-injection

tested with Apple clang version 12.0.0 (clang-1200.0.32.29)

ClausKlein and others added 4 commits February 4, 2021 00:28
extent build_all.py to inject cmake modules
and use Ninja generator
use SYSTEM include paths (for clang++)
we should not use local installed header!
finalize cmake project code injection as an option
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the issue and PR! It was about time to give the examples some love and update the dependencies to recent versions.

examples/asio-standalone/CMakeLists.txt Outdated Show resolved Hide resolved
examples/build_all.py Outdated Show resolved Hide resolved
examples/build_all.py Outdated Show resolved Hide resolved
examples/build_all.py Outdated Show resolved Hide resolved
examples/build_all.py Outdated Show resolved Hide resolved
examples/gtest/CMakeLists.txt Outdated Show resolved Hide resolved
@TheLartians TheLartians linked an issue Feb 4, 2021 that may be closed by this pull request
ClausKlein and others added 2 commits February 4, 2021 18:34
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
indent with only 2 spaces again
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the formatting! I'd still like the above issues to be addressed before merging.

@TheLartians
Copy link
Member

As for the apparently system-dependent issues appearing on your setup, could you check if they still arise if you don't use CMAKE_PROJECT_INCLUDE_BEFORE and CMAKE_PROJECT_INCLUDE to build the examples?

the gtest build error seems to be a make -j cpucount problem
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR and updates!

@TheLartians TheLartians merged commit 5f614e5 into cpm-cmake:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with examples on macOS with apple clang
2 participants