Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml-cpp git tag in README #197

Closed
wants to merge 1 commit into from

Conversation

dstansby
Copy link

yaml-cpp 0.6.3 is released, so I've updated the tag in the README to the tag for 0.6.3 (see https://github.com/jbeder/yaml-cpp/releases/tag/yaml-cpp-0.6.3)

@TheLartians
Copy link
Member

Hey, thanks for the PR! We've already updated yaml-cpp (and other examples) in a previous PR.

@dstansby dstansby deleted the patch-1 branch February 15, 2021 10:54
@TheLartians
Copy link
Member

TheLartians commented Feb 16, 2021

@dstansby I just now realised that you've updated the Readme while the PR handled the examples ... Sorry for not checking properly before. You're definitely right that the example in the Readme could be updated as well! If you want, you can reopen the PR and I'll be happy to review and add the changes!

On that note, if you want to reopen, it would be great of you could reference the tag yaml-cpp-0.6.3 instead of the commit hash, as it is more clear to be synchronised to the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants