Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr reviews #26

Closed
wants to merge 3 commits into from
Closed

Test pr reviews #26

wants to merge 3 commits into from

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Jan 6, 2024

time to test our generated PR reviews

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed stale reviews from themself January 6, 2024 08:11

outdated suggestion

@2bndy5 2bndy5 marked this pull request as ready for review January 6, 2024 08:15
@2bndy5 2bndy5 closed this Jan 6, 2024
@2bndy5 2bndy5 reopened this Jan 6, 2024
github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 09:21

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 09:31

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 19:26

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 19:30

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed stale reviews from themself January 6, 2024 21:43

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 21:58

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 22:04

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot dismissed their stale review January 6, 2024 22:17

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

@2bndy5 2bndy5 closed this Jan 6, 2024
github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as outdated.

Copy link

github-actions bot commented Jan 7, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted
  • src/demo.cpp
  • src/demo.hpp
clang-tidy reports: 4 concern(s)
  • src/demo.cpp

    src/demo.cpp:3:10: warning: [modernize-deprecated-headers]

    inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead

    #include <stdio.h>
             ^~~~~~~~~
             <cstdio>
  • src/demo.cpp

    src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

    int main(){
    ~~~ ^
    auto       -> int
  • src/demo.cpp

    src/demo.cpp:10:13: warning: [readability-braces-around-statements]

    statement should be inside braces

        for (;;) break;
                ^
                 {
  • src/demo.hpp

    src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

        void *not_useful(char *str){useless = str;}
        ~~~~~~^
        auto                        -> void *

Have any feedback or feature suggestions? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Only 6 out of 7 clang-format suggestions fit within this pull request's diff.

Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..c522998 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..8f92cac 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -8 +8,5 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
@@ -11 +15 @@ class Dummy {
-    void *not_useful(char *str){useless = str;}
+        void* not_useful(char* str) { useless = str; }
@@ -14,17 +17,0 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
@@ -34,2 +21 @@ struct LongDiff
-    long diff;
-
+        long diff;
Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +17,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..2591c48 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -11 +11 @@ class Dummy {
-    void *not_useful(char *str){useless = str;}
+        auto not_useful(char* str) -> void* { useless = str; }

src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.hpp Show resolved Hide resolved
src/demo.hpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.cpp Show resolved Hide resolved
src/demo.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant