Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr reviews #26

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/cpp-lint-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,17 @@ on:
description: 'which branch to test'
default: 'main'
required: true
pull_request:

jobs:
cpp-linter:
runs-on: windows-latest

strategy:
matrix:
clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17']
clang-version: ['10', '11', '12', '13', '14', '15', '16', '17']
repo: ['cpp-linter/cpp-linter']
branch: ['${{ inputs.branch }}']
branch: ['pr-review-suggestions']
fail-fast: false

steps:
Expand Down Expand Up @@ -62,10 +63,12 @@ jobs:
-i=build
-p=build
-V=${{ runner.temp }}/llvm
-f=false
--extra-arg="-std=c++14 -Wall"
--thread-comments=${{ matrix.clang-version == '12' }}
-a=${{ matrix.clang-version == '12' }}
--file-annotations=false
--lines-changed-only=true
--thread-comments=${{ matrix.clang-version == '16' }}
--tidy-review=${{ matrix.clang-version == '16' }}
--format-review=${{ matrix.clang-version == '16' }}

- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
Expand Down
21 changes: 11 additions & 10 deletions src/demo.cpp
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
/** This is a very ugly test code (doomed to fail linting) */
#include "demo.hpp"
#include <cstdio>
#include <cstddef>
#include <stdio.h>
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
// using size_t from cstddef
size_t dummyFunc(size_t i) { return i; }

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
int main()
{
for (;;)
break;


int main(){

for (;;) break;

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
printf("Hello world!\n");
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

return 0;
}



return 0;}
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 3 additions & 8 deletions src/demo.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
class Dummy {
char* useless;
int numb;
Dummy() :numb(0), useless("\0"){}
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
};
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved

Expand All @@ -28,14 +26,11 @@ class Dummy {









struct LongDiff
{

long diff;

2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
};
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved
2bndy5 marked this conversation as resolved.
Show resolved Hide resolved