Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_port() takes a scheme but not a protocol() #135

Closed
AlexandreBossard opened this issue Jun 30, 2020 · 2 comments
Closed

default_port() takes a scheme but not a protocol() #135

AlexandreBossard opened this issue Jun 30, 2020 · 2 comments
Assignees
Milestone

Comments

@AlexandreBossard
Copy link

auto const myurl = url("https://exampe.com");
url::default_port(myurl.protocol()).has_value(); // false

So, protocol() returns https: but default_port() needs a scheme (no ':'). Plus, there is no url::scheme() provided. Is this some overlooking ? Having to strip the ':' every time is annoying.

@glynos
Copy link
Member

glynos commented Jun 30, 2020

That's a simple fix, I'd appreciate a short review of #136 to make sure I captured what you asked for.

@glynos glynos added this to To do in Feature-complete, stable API via automation Jun 30, 2020
@glynos glynos added this to the v2.0 milestone Jun 30, 2020
@glynos
Copy link
Member

glynos commented Jul 1, 2020

Fixed in #136

@glynos glynos closed this as completed Jul 1, 2020
Feature-complete, stable API automation moved this from To do to Done Jul 1, 2020
GerHobbelt pushed a commit to GerHobbelt/url that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants