Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic Hunter package release / easy setup with FetchContent #2

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

cristianadam
Copy link

No description provided.

Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Would things like HUNTER_PASSWORDS_PATH still work as intended in this setup? https://docs.hunter.sh/en/latest/reference/terminology/hunter-passwords-file.html

@rbsheth rbsheth merged commit da49d65 into cpp-pm:master Nov 4, 2019
@cristianadam
Copy link
Author

Awesome, thanks! Would things like HUNTER_PASSWORDS_PATH still work as intended in this setup? https://docs.hunter.sh/en/latest/reference/terminology/hunter-passwords-file.html

I think so. FetchContent_MakeAvailable does as add_subdirectory and all the variables set for the project will be available to the gate project.

@bkotzz
Copy link
Member

bkotzz commented Nov 5, 2019

Looks like this isn’t working as expected? cpp-pm/hunter#56

CC @rbsheth @cristianadam

@cristianadam
Copy link
Author

Looks like this isn’t working as expected? cpp-pm/hunter#56

CC @rbsheth @cristianadam

Oh boy, that's embarassing. I've pushed a MR. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants