Add 'libarchive' package #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstack
commented
Oct 18, 2020
tstack
commented
- I've followed this guide step by step carefully. Yes
- My change will resolve this "New package" request: Add "libarchive" package #182
rbsheth
reviewed
Oct 20, 2020
There was a problem hiding this comment.
@tstack Thanks for this PR! It seems like upstream has a CMakeLists.txt file now - can we use that? Would be useful to get things working on Windows also.
https://github.com/libarchive/libarchive/blob/master/CMakeLists.txt
|
It sounded like the CMakeLists.txt would need to be forked/patched, which I'd rather not do. So, I went the autotools route. Has there been any progress on getting hunter working without needing to do forks of packages? |
rbsheth
approved these changes
Oct 30, 2020
|
And no, we haven't implemented fork-free packages yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.