Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (lack of) building without C++11 support #497

Closed
wants to merge 3 commits into from

Conversation

grisumbras
Copy link
Member

No description provided.

@grisumbras
Copy link
Member Author

This should fix Boost builds without C++11 support

@vinniefalco
Copy link
Member

Suggested commit message: "Builds prior to C++11 are no-ops"

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #497 (2f1c258) into develop (f0ea69f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #497   +/-   ##
========================================
  Coverage    99.10%   99.10%           
========================================
  Files           67       67           
  Lines         6047     6047           
========================================
  Hits          5993     5993           
  Misses          54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ea69f...ffc82d3. Read the comment docs.

@grisumbras
Copy link
Member Author

Do you think there's a need for CI test for no-op build with cxxstd=03?

@vinniefalco
Copy link
Member

Please change "Adds back GCC 4.8 support" to "gcc-4.8 is supported"

@vinniefalco
Copy link
Member

Do you think there's a need for CI test for no-op build with cxxstd=03?

Up to you

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

@vinniefalco
Copy link
Member

Can we please change the commit message to "gcc-4.8 is supported" ? Use an interactive rebase (git rebase -i) then force-push the branch.

@grisumbras
Copy link
Member Author

Which commit?

@vinniefalco
Copy link
Member

This one:
image

vinniefalco pushed a commit to vinniefalco/json that referenced this pull request Feb 9, 2021
@cppalliance-bot
Copy link

@grisumbras grisumbras deleted the fix-cxx-03-build branch March 10, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants